From: Gao Xiang <gaoxiang25@huawei.com>
To: Vladimir Zapolskiy <vladimir@tuxera.com>
Cc: Miao Xie <miaoxie@huawei.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, Gao Xiang <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org,
Anton Altaparmakov <anton@tuxera.com>
Subject: Re: [PATCH 0/3] erofs: remove tags of pointers stored in a radix tree
Date: Thu, 2 Jan 2020 20:55:51 +0800 [thread overview]
Message-ID: <20200102125551.GB53770@architecture4> (raw)
In-Reply-To: <20200102120118.14979-1-vladimir@tuxera.com>
Hi Vladimir,
On Thu, Jan 02, 2020 at 02:01:15PM +0200, Vladimir Zapolskiy wrote:
> The changeset simplifies a couple of internal interfaces and removes
> excessive tagging and untagging of workgroup pointers stored in a radix
> tree.
>
> All the changes in the series are non-functional.
This radix tree tag was planned to be reserved for other use in order
to differ it from the current fixed-sized output compression management
structure. I agree that it can be simplified for now, so I will test
this series and apply. However, I think such XArray tagged pointer
usage is useful.
p.s. I'm converting this radix tree to XArray and cleaning up
related functions for the next cycle as well.
Thanks,
Gao Xiang
>
> Vladimir Zapolskiy (3):
> erofs: remove unused tag argument while finding a workgroup
> erofs: remove unused tag argument while registering a workgroup
> erofs: remove void tagging/untagging of workgroup pointers
>
> fs/erofs/internal.h | 4 ++--
> fs/erofs/utils.c | 15 ++++-----------
> fs/erofs/zdata.c | 5 ++---
> 3 files changed, 8 insertions(+), 16 deletions(-)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-01-02 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 12:01 [PATCH 0/3] erofs: remove tags of pointers stored in a radix tree Vladimir Zapolskiy
2020-01-02 12:01 ` [PATCH 1/3] erofs: remove unused tag argument while finding a workgroup Vladimir Zapolskiy
2020-01-02 12:01 ` [PATCH 2/3] erofs: remove unused tag argument while registering " Vladimir Zapolskiy
2020-01-02 12:01 ` [PATCH 3/3] erofs: remove void tagging/untagging of workgroup pointers Vladimir Zapolskiy
2020-01-02 12:55 ` Gao Xiang [this message]
2020-01-03 7:08 ` [PATCH 0/3] erofs: remove tags of pointers stored in a radix tree Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102125551.GB53770@architecture4 \
--to=gaoxiang25@huawei.com \
--cc=anton@tuxera.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=vladimir@tuxera.com \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).