From: Gao Xiang <hsiangkao@redhat.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] erofs: remove unneeded parameter
Date: Thu, 17 Sep 2020 10:21:10 +0800 [thread overview]
Message-ID: <20200917022110.GA18734@xiangao.remote.csb> (raw)
In-Reply-To: <20200917011821.22767-1-yuchao0@huawei.com>
On Thu, Sep 17, 2020 at 09:18:21AM +0800, Chao Yu wrote:
> After commit 0615090c5044 ("erofs: convert compressed files from
> readpages to readahead"), add_to_page_cache_lru() was moved to mm
> code, so that in below call path, no page will be cached into
> @pagepool list or grabbed from @pagepool list:
> - z_erofs_readpage
> - z_erofs_do_read_page
> - preload_compressed_pages
> - erofs_allocpage
>
> Let's get rid of this unneeded @pagepool parameter.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
Will apply it later :)
Thanks,
Gao Xiang
prev parent reply other threads:[~2020-09-17 2:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 1:18 [PATCH v2] erofs: remove unneeded parameter Chao Yu
2020-09-17 2:21 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917022110.GA18734@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).