From: Gao Xiang <hsiangkao@redhat.com>
To: Vladimir Zapolskiy <vladimir@tuxera.com>
Cc: Gao Xiang <xiang@kernel.org>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile
Date: Fri, 30 Oct 2020 20:34:19 +0800 [thread overview]
Message-ID: <20201030123419.GA133455@xiangao.remote.csb> (raw)
In-Reply-To: <20201030122839.25431-1-vladimir@tuxera.com>
On Fri, Oct 30, 2020 at 02:28:39PM +0200, Vladimir Zapolskiy wrote:
> Since commit 4f761fa253b4 ("erofs: rename errln/infoln/debugln to
> erofs_{err, info, dbg}") the defined macro EROFS_VERSION has no affect,
> therefore removing it from the Makefile is a non-functional change.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
> ---
Yeah, since we have feature bits now, and fs runtime version
isn't very important... Thanks for doing this!
Reviewed-by: Gao Xiang <hsiangkao@redhat.com>
Thanks,
Gao Xiang
next prev parent reply other threads:[~2020-10-30 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 12:28 [PATCH] erofs: remove a void EROFS_VERSION macro set in Makefile Vladimir Zapolskiy
2020-10-30 12:34 ` Gao Xiang [this message]
2020-12-08 7:44 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030123419.GA133455@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=vladimir@tuxera.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).