From: Gao Xiang <hsiangkao@redhat.com>
To: 胡玮文 <sehuww@mail.scut.edu.cn>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: fix battach on full buffer block
Date: Thu, 21 Jan 2021 17:22:54 +0800 [thread overview]
Message-ID: <20210121092254.GA2902889@xiangao.remote.csb> (raw)
In-Reply-To: <20210121060738.GA6680@DESKTOP-N4CECTO.huww98.cn>
On Thu, Jan 21, 2021 at 02:07:38PM +0800, 胡玮文 wrote:
...
>
> I've downloaded "tests/results/" and it's test 007 (check for bad lz4 versions)
> that fails with output "test LZ4_compress_HC_destSize(1048576) error (4098 <
> 4116)". And it's the same error on my PC. Investigating.
>
> BTW, why not use a more meaningful name for each test rather than a sequence
> number?
I'm not good at English naming (but such cases need stable names),
also see xfstests:
https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/tests/xfs
the meaningful description can be written down at tests/Makefile.am...
Yet they have no interest in integrating such testcases (also generic/
cases are not useful for EROFS either), and EROFS has many specific
optimized paths so I decided to make a light-weight regression
testcases in erofs-utils to look after it and kernel EROFS...
Thanks,
Gao Xiang
>
> Hu Weiwen
next prev parent reply other threads:[~2021-01-21 9:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 12:39 [PATCH] erofs-utils: fix battach on full buffer block Hu Weiwen
2021-01-18 13:59 ` Gao Xiang
2021-01-18 15:52 ` 胡玮文
2021-01-18 23:28 ` Gao Xiang
2021-01-19 6:02 ` 胡玮文
2021-01-19 15:43 ` Gao Xiang
2021-01-20 4:57 ` 胡玮文
2021-01-20 5:12 ` Gao Xiang
2021-01-21 6:07 ` 胡玮文
2021-01-21 7:22 ` 胡玮文
2021-01-21 9:22 ` Gao Xiang [this message]
2021-01-21 16:26 ` [PATCH v2] " Hu Weiwen
2021-01-22 2:31 ` Gao Xiang
2021-01-22 12:43 ` Gao Xiang
2021-02-14 15:22 ` Gao Xiang via Linux-erofs
2021-02-14 16:00 ` [PATCH v3] erofs-utils: fix battach on full buffer blocks Gao Xiang via Linux-erofs
2021-02-22 15:34 ` Li GuiFu via Linux-erofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121092254.GA2902889@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=sehuww@mail.scut.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).