From: Gao Xiang <hsiangkao@redhat.com>
To: Huang Jianan <huangjianan@oppo.com>
Cc: zhangshiming@oppo.com, guoweichao@oppo.com,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] erofs: support adjust lz4 history window size
Date: Tue, 23 Feb 2021 13:25:58 +0800 [thread overview]
Message-ID: <20210223052558.GC1225203@xiangao.remote.csb> (raw)
In-Reply-To: <20210223051926.GB1225203@xiangao.remote.csb>
(cont. the previous reply)
On Tue, Feb 23, 2021 at 01:19:26PM +0800, Gao Xiang wrote:
...
> > + __le16 lz4_max_distance; /* lz4 max distance */
unneeded comment.
> > + __u8 reserved2[42];
> > };
> >
> > /*
> > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> > index 67a7ec945686..7457710a763a 100644
> > --- a/fs/erofs/internal.h
> > +++ b/fs/erofs/internal.h
> > @@ -70,6 +70,9 @@ struct erofs_sb_info {
> >
> > /* pseudo inode to manage cached pages */
> > struct inode *managed_cache;
> > +
> > + /* lz4 max distance pages */
> > + u16 lz4_max_distance_pages;
useless comment as well... maybe we could add some descriptive
words, e.g.
/* # of pages needed for EROFS lz4 rolling decompression */
Thanks,
Gao Xiang
prev parent reply other threads:[~2021-02-23 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 4:36 [PATCH v2] erofs: support adjust lz4 history window size Huang Jianan via Linux-erofs
2021-02-23 5:19 ` Gao Xiang
2021-02-23 5:25 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223052558.GC1225203@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=guoweichao@oppo.com \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).