linux-erofs.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@redhat.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: Martin DEVERA <devik@eaxlabs.cz>,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] erofs: fix bio->bi_max_vecs behavior change
Date: Mon, 8 Mar 2021 10:36:50 +0800	[thread overview]
Message-ID: <20210308023650.GA3537842@xiangao.remote.csb> (raw)
In-Reply-To: <6525c63c-a6e2-8c39-6c9a-1ca9b54632d8@huawei.com>

Hi Chao,

On Mon, Mar 08, 2021 at 09:29:30AM +0800, Chao Yu wrote:
> On 2021/3/6 12:04, Gao Xiang wrote:
> > From: Gao Xiang <hsiangkao@redhat.com>
> > 
> > Martin reported an issue that directory read could be hung on the
> > latest -rc kernel with some certain image. The root cause is that
> > commit baa2c7c97153 ("block: set .bi_max_vecs as actual allocated
> > vector number") changes .bi_max_vecs behavior. bio->bi_max_vecs
> > is set as actual allocated vector number rather than the requested
> > number now.
> > 
> > Let's avoid using .bi_max_vecs completely instead.
> > 
> > Reported-by: Martin DEVERA <devik@eaxlabs.cz>
> > Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> 
> Looks good to me, btw, it needs to Cc stable mailing list?
> 
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> 

Thanks for your review. <= 5.11 kernels are not impacted.
For now, this only impacts 5.12-rc due to a bio behavior
change (see commit baa2c7c97153). So personally I think
just leave as it is is fine.

Thanks,
Gao Xiang

> Thanks,
> 


  reply	other threads:[~2021-03-08  2:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210306033109.28466-1-hsiangkao.ref@aol.com>
2021-03-06  3:31 ` [PATCH] erofs: fix bio->bi_max_vecs behavior change Gao Xiang via Linux-erofs
2021-03-06  4:04   ` [PATCH v2] " Gao Xiang via Linux-erofs
2021-03-08  1:29     ` Chao Yu
2021-03-08  2:36       ` Gao Xiang [this message]
2021-03-08  2:52         ` Chao Yu
2021-03-08  3:01           ` Gao Xiang
2021-03-19  2:15     ` Chao Yu
2021-03-19  4:16       ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210308023650.GA3537842@xiangao.remote.csb \
    --to=hsiangkao@redhat.com \
    --cc=devik@eaxlabs.cz \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).