From: Li GuiFu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <hsiangkao@redhat.com>,
linux-erofs@lists.ozlabs.org, Yue Hu <zbestahu@gmail.com>,
Huang Jianan <huangjianan@oppo.com>
Cc: Yue Hu <huyue2@yulong.com>
Subject: Re: [PATCH v2] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config
Date: Fri, 1 Jan 2021 00:46:38 +0800 [thread overview]
Message-ID: <37f07049-1cba-b398-5049-d76e543f9e02@aliyun.com> (raw)
In-Reply-To: <20201228105146.2939914-1-hsiangkao@redhat.com>
On 2020/12/28 18:51, Gao Xiang wrote:
> From: Gao Xiang <hsiangkao@aol.com>
>
> "failed to find [%s] in canned fs_config" was observed by using
> "--fs-config-file" option as reported by Yue Hu [1].
>
> The root cause was that the mountpoint prefix to subdirectories is
> also needed if "--mount-point" presents. However, such prefix cannot
> be added by just using erofs_fspath().
>
> One exception is that the root directory itself needs to be handled
> specially for canned fs_config. For such case, the prefix of the root
> directory has to be dropped instead.
>
> [1] https://lkml.kernel.org/r/20201222020430.12512-1-zbestahu@gmail.com
>
> Link: https://lore.kernel.org/r/20201226062736.29920-1-hsiangkao@aol.com
> Fixes: 8a9e8046f170 ("AOSP: erofs-utils: add fs_config support")
> Reported-by: Yue Hu <huyue2@yulong.com>
> Signed-off-by: Gao Xiang <hsiangkao@aol.com>
> ---
> changes since v2:
> - fix IS_ROOT misuse reported by Jianan, very sorry about this since
> I know little about canned fs_config.
>
> (please kindly test again...)
>
> lib/inode.c | 39 +++++++++++++++++++++++++--------------
> 1 file changed, 25 insertions(+), 14 deletions(-)
>
It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>
Thanks,
prev parent reply other threads:[~2020-12-31 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201226062736.29920-1-hsiangkao.ref@aol.com>
2020-12-26 6:27 ` [PATCH] AOSP: erofs-utils: fix sub-directory prefix for canned fs_config Gao Xiang via Linux-erofs
2020-12-28 7:05 ` Yue Hu
2020-12-28 10:03 ` Huang Jianan
2020-12-28 10:48 ` Gao Xiang
2020-12-28 10:51 ` [PATCH v2] " Gao Xiang
2020-12-28 11:14 ` Huang Jianan
2020-12-28 11:20 ` Yue Hu
2020-12-28 11:32 ` Gao Xiang
2020-12-28 11:39 ` Yue Hu
2020-12-28 11:46 ` Yue Hu
2020-12-28 12:43 ` Gao Xiang
2020-12-31 16:31 ` Li GuiFu via Linux-erofs
2020-12-31 16:50 ` Gao Xiang
2020-12-31 16:46 ` Li GuiFu via Linux-erofs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f07049-1cba-b398-5049-d76e543f9e02@aliyun.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=bluce.lee@aliyun.com \
--cc=hsiangkao@redhat.com \
--cc=huangjianan@oppo.com \
--cc=huyue2@yulong.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).