From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876CDC433E0 for ; Mon, 8 Mar 2021 01:45:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FB506514C for ; Mon, 8 Mar 2021 01:45:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FB506514C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Dv1PL2wCHz3cKP for ; Mon, 8 Mar 2021 12:45:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.190; helo=szxga04-in.huawei.com; envelope-from=yuchao0@huawei.com; receiver=) X-Greylist: delayed 920 seconds by postgrey-1.36 at boromir; Mon, 08 Mar 2021 12:45:08 AEDT Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dv1PJ1Sfbz30Qk for ; Mon, 8 Mar 2021 12:45:04 +1100 (AEDT) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Dv11K63Mlz16HZg; Mon, 8 Mar 2021 09:27:49 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.498.0; Mon, 8 Mar 2021 09:29:31 +0800 Subject: Re: [PATCH v2] erofs: fix bio->bi_max_vecs behavior change To: Gao Xiang , , Chao Yu References: <20210306033109.28466-1-hsiangkao@aol.com> <20210306040438.8084-1-hsiangkao@aol.com> From: Chao Yu Message-ID: <6525c63c-a6e2-8c39-6c9a-1ca9b54632d8@huawei.com> Date: Mon, 8 Mar 2021 09:29:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210306040438.8084-1-hsiangkao@aol.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin DEVERA , linux-kernel@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2021/3/6 12:04, Gao Xiang wrote: > From: Gao Xiang > > Martin reported an issue that directory read could be hung on the > latest -rc kernel with some certain image. The root cause is that > commit baa2c7c97153 ("block: set .bi_max_vecs as actual allocated > vector number") changes .bi_max_vecs behavior. bio->bi_max_vecs > is set as actual allocated vector number rather than the requested > number now. > > Let's avoid using .bi_max_vecs completely instead. > > Reported-by: Martin DEVERA > Signed-off-by: Gao Xiang Looks good to me, btw, it needs to Cc stable mailing list? Reviewed-by: Chao Yu Thanks,