From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Baokun Li <libaokun1@huawei.com>, linux-erofs@lists.ozlabs.org
Cc: brauner@kernel.org, yangerkun@huawei.com,
linux-kernel@vger.kernel.org, huyue2@coolpad.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH -next v3 2/2] erofs: reliably distinguish block based and fscache mode
Date: Mon, 22 Apr 2024 19:52:27 +0800 [thread overview]
Message-ID: <f8f77b76-e2a0-4e8c-900e-eed569ca7136@linux.alibaba.com> (raw)
In-Reply-To: <20240419123611.947084-3-libaokun1@huawei.com>
On 4/19/24 8:36 PM, Baokun Li wrote:
> From: Christian Brauner <brauner@kernel.org>
>
> When erofs_kill_sb() is called in block dev based mode, s_bdev may not
> have been initialised yet, and if CONFIG_EROFS_FS_ONDEMAND is enabled,
> it will be mistaken for fscache mode, and then attempt to free an anon_dev
> that has never been allocated, triggering the following warning:
>
> ============================================
> ida_free called for id=0 which is not allocated.
> WARNING: CPU: 14 PID: 926 at lib/idr.c:525 ida_free+0x134/0x140
> Modules linked in:
> CPU: 14 PID: 926 Comm: mount Not tainted 6.9.0-rc3-dirty #630
> RIP: 0010:ida_free+0x134/0x140
> Call Trace:
> <TASK>
> erofs_kill_sb+0x81/0x90
> deactivate_locked_super+0x35/0x80
> get_tree_bdev+0x136/0x1e0
> vfs_get_tree+0x2c/0xf0
> do_new_mount+0x190/0x2f0
> [...]
> ============================================
>
> Now when erofs_kill_sb() is called, erofs_sb_info must have been
> initialised, so use sbi->fsid to distinguish between the two modes.
>
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> ---
> fs/erofs/super.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 21faa49bc970..30b49b2eee53 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -789,17 +789,13 @@ static int erofs_init_fs_context(struct fs_context *fc)
>
> static void erofs_kill_sb(struct super_block *sb)
> {
> - struct erofs_sb_info *sbi;
> + struct erofs_sb_info *sbi = EROFS_SB(sb);
>
> - if (erofs_is_fscache_mode(sb))
> + if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && sbi->fsid)
> kill_anon_super(sb);
> else
> kill_block_super(sb);
>
> - sbi = EROFS_SB(sb);
> - if (!sbi)
> - return;
> -
> erofs_free_dev_context(sbi->devs);
> fs_put_dax(sbi->dax_dev, NULL);
> erofs_fscache_unregister_fs(sb);
--
Thanks,
Jingbo
next prev parent reply other threads:[~2024-04-22 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 12:36 [PATCH -next v3 0/2] erofs: reliably distinguish block based and fscache mode Baokun Li via Linux-erofs
2024-04-19 12:36 ` [PATCH -next v3 1/2] erofs: get rid of erofs_fs_context Baokun Li via Linux-erofs
2024-04-22 10:25 ` Jingbo Xu
2024-04-22 11:31 ` Baokun Li via Linux-erofs
2024-04-22 11:39 ` Jingbo Xu
2024-04-23 10:37 ` Gao Xiang
2024-04-28 7:10 ` Gao Xiang
2024-04-28 10:00 ` Chao Yu
2024-04-19 12:36 ` [PATCH -next v3 2/2] erofs: reliably distinguish block based and fscache mode Baokun Li via Linux-erofs
2024-04-22 11:52 ` Jingbo Xu [this message]
2024-04-28 7:17 ` Gao Xiang
2024-04-28 10:03 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f77b76-e2a0-4e8c-900e-eed569ca7136@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=huyue2@coolpad.com \
--cc=libaokun1@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).