linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Shuning Zhang <sunny.s.zhang@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: Adjust the comment of function ext2_alloc_branch
Date: Tue, 19 Mar 2019 11:48:52 +0100	[thread overview]
Message-ID: <20190319104852.GB20138@quack2.suse.cz> (raw)
In-Reply-To: <1551836855-10316-1-git-send-email-sunny.s.zhang@oracle.com>

On Wed 06-03-19 09:47:35, Shuning Zhang wrote:
> The name of argument is error in the header comment.
> @num should be @indirect_blks.
> At the same time, there was a lack of description of the two parameters
> @blks and @goal.
> This commit therefore fixes this header comment.
> 
> Signed-off-by: Shuning Zhang <sunny.s.zhang@oracle.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/inode.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index e4bb938..3f404c3 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -451,7 +451,9 @@ static int ext2_alloc_blocks(struct inode *inode,
>  /**
>   *	ext2_alloc_branch - allocate and set up a chain of blocks.
>   *	@inode: owner
> - *	@num: depth of the chain (number of blocks to allocate)
> + *	@indirect_blks: depth of the chain (number of blocks to allocate)
> + *	@blks: number of allocated direct blocks
> + *	@goal: preferred place for allocation
>   *	@offsets: offsets (in the blocks) to store the pointers to next.
>   *	@branch: place to store the chain in.
>   *
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2019-03-19 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  1:47 [PATCH] ext2: Adjust the comment of function ext2_alloc_branch Shuning Zhang
2019-03-19 10:48 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190319104852.GB20138@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sunny.s.zhang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).