From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix dcache lookup of !casefolded directories
Date: Fri, 24 May 2019 23:58:47 -0400 [thread overview]
Message-ID: <20190525035847.GC4225@mit.edu> (raw)
In-Reply-To: <20190524224129.28525-1-krisman@collabora.com>
On Fri, May 24, 2019 at 06:41:29PM -0400, Gabriel Krisman Bertazi wrote:
> Found by visual inspection, this wasn't caught by my xfstest, since it's
> effect is ignoring positive dentries in the cache the fallback just goes
> to the disk. it was introduced in the last iteration of the
> case-insensitive patch.
>
> d_compare should return 0 when the entries match, so make sure we are
> correctly comparing the entire string if the encoding feature is set and
> we are on a case-INsensitive directory.
>
> Fixes: b886ee3e778e ("ext4: Support case-insensitive file name lookups")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Applied, thanks.
I'll note that half the implementations of *_d_compare seem to use
!!memcmp(), and half use memcmp().
The callers of d_compare only seems to care if it's 0 or != 0, so I
guess it doesn't matter...
- Ted
prev parent reply other threads:[~2019-05-25 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 22:41 [PATCH] ext4: Fix dcache lookup of !casefolded directories Gabriel Krisman Bertazi
2019-05-25 3:58 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190525035847.GC4225@mit.edu \
--to=tytso@mit.edu \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).