From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Matthew Bobrowski <mbobrowski@mbobrowski.org>,
linux-ext4@vger.kernel.org, Ted Tso <tytso@mit.edu>
Subject: Re: Splice & iomap dio problems
Date: Tue, 19 Nov 2019 08:48:45 -0800 [thread overview]
Message-ID: <20191119164845.GA22763@infradead.org> (raw)
In-Reply-To: <20191119163454.GS6235@magnolia>
On Tue, Nov 19, 2019 at 08:34:54AM -0800, Darrick J. Wong wrote:
> > The slight concern I have with this is that that would change e.g. the
> > behavior of IOMAP_REPORT. We could specialcase IOMAP_REPORT but then it
> > gets kind of ugly. And it seems kind of fuzzy when do we truncate the
> > extent with i_size and when not... Generally i_size is kind of a side-band
> > thing for block mapping operations so if we could leave it out of
> > ->iomap_begin I'd find that nicer.
>
> <nod>
Yes. I'd prefer if the caller deals with any i_size limiting and
not the iomap methods themselves. For now I'm tempted to just go
with the iov_iter_revert scheme. Note that I particularly like it,
but it matches the most common direct I/O implementation at least.
prev parent reply other threads:[~2019-11-19 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 18:00 Splice & iomap dio problems Jan Kara
2019-11-13 18:44 ` Darrick J. Wong
2019-11-19 16:32 ` Jan Kara
2019-11-19 16:34 ` Darrick J. Wong
2019-11-19 16:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119164845.GA22763@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).