From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH -v3] ext4: simulate various I/O and checksum errors when reading metadata
Date: Fri, 13 Dec 2019 13:45:52 -0500 [thread overview]
Message-ID: <20191213184552.GB273569@mit.edu> (raw)
In-Reply-To: <14336F5B-D8D2-4B73-A60C-3B63997F0827@dilger.ca>
On Sun, Dec 08, 2019 at 09:14:08PM -0700, Andreas Dilger wrote:
>
> This should be marked unlikely(), as it is definitely one of the places
> that is legitimately rarely true. Sorry for not pointing this out on
> the previous version of the patch.
Good point; thanks, I've made that change.
- Ted
next prev parent reply other threads:[~2019-12-13 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 3:23 [PATCH -v2 1/2] ext4: save the error code which triggered an ext4_error() in the superblock Theodore Ts'o
2019-12-04 3:23 ` [PATCH -v2 2/2] ext4: simulate various I/O and checksum errors when reading metadata Theodore Ts'o
2019-12-05 19:05 ` Andreas Dilger
2019-12-09 1:23 ` [PATCH -v3] " Theodore Ts'o
2019-12-09 4:14 ` Andreas Dilger
2019-12-13 18:45 ` Theodore Y. Ts'o [this message]
2019-12-13 11:29 ` [PATCH -v2 1/2] ext4: save the error code which triggered an ext4_error() in the superblock Jan Kara
2019-12-13 18:50 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213184552.GB273569@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).