From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Phong Tran <tranmanphong@gmail.com>
Cc: jack@suse.cz, adilger.kernel@dilger.ca, paulmck@kernel.org,
joel@joelfernandes.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
rcu@vger.kernel.org
Subject: Re: [PATCH V2] ext4: use rcu API in debug_print_tree
Date: Sun, 15 Dec 2019 21:41:54 -0500 [thread overview]
Message-ID: <20191216024154.GB11512@mit.edu> (raw)
In-Reply-To: <20191213153306.30744-1-tranmanphong@gmail.com>
On Fri, Dec 13, 2019 at 10:33:07PM +0700, Phong Tran wrote:
> struct ext4_sb_info.system_blks was marked __rcu.
> But access the pointer without using RCU lock and dereference.
> Sparse warning with __rcu notation:
>
> block_validity.c:139:29: warning: incorrect type in argument 1 (different address spaces)
> block_validity.c:139:29: expected struct rb_root const *
> block_validity.c:139:29: got struct rb_root [noderef] <asn:4> *
>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2019-12-16 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 3:51 [PATCH] ext4: use rcu API in debug_print_tree Phong Tran
2019-12-13 11:35 ` Jan Kara
2019-12-13 15:33 ` [PATCH V2] " Phong Tran
2019-12-13 18:11 ` Joel Fernandes
2019-12-13 19:49 ` Jan Kara
2019-12-13 23:19 ` Joel Fernandes
2019-12-16 2:41 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216024154.GB11512@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=joel@joelfernandes.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).