From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: export information about first/last errors via /sys/fs/ext4/<dev>
Date: Thu, 9 Jan 2020 12:24:51 -0500 [thread overview]
Message-ID: <20200109172451.GD33929@mit.edu> (raw)
In-Reply-To: <20200109091240.GA27035@quack2.suse.cz>
On Thu, Jan 09, 2020 at 10:12:40AM +0100, Jan Kara wrote:
> On Mon 23-12-19 19:05:41, Theodore Ts'o wrote:
> > Make {first,last}_error_{ino,block,line,func,errcode} available via
> > sysfs.
> >
> > Also add a missing newline for {first,last}_error_time.
> >
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>
> The patch looks good to me. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> I'm just wondering a bit why do you need this? Some system monitoring
> thing?
Yes, precisely. Especially in cloud environments, where the disk
often gets deleted when the VM is terminated, so reading the this
information from the superblock won't be possible.
- Ted
prev parent reply other threads:[~2020-01-09 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 0:05 [PATCH] ext4: export information about first/last errors via /sys/fs/ext4/<dev> Theodore Ts'o
2020-01-09 9:12 ` Jan Kara
2020-01-09 17:24 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109172451.GD33929@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).