From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDB1C33CB1 for ; Thu, 16 Jan 2020 15:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DF6320730 for ; Thu, 16 Jan 2020 15:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbgAPPMx (ORCPT ); Thu, 16 Jan 2020 10:12:53 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36308 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726151AbgAPPMx (ORCPT ); Thu, 16 Jan 2020 10:12:53 -0500 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 00GFCe9c029404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Jan 2020 10:12:43 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 68A044207DF; Thu, 16 Jan 2020 10:12:39 -0500 (EST) Date: Thu, 16 Jan 2020 10:12:39 -0500 From: "Theodore Y. Ts'o" To: Jan Kara Cc: Naoto Kobayashi , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2 2/3] ext4: Rename ext4_kvmalloc() to ext4_kvmalloc_nofs() and drop its flags argument Message-ID: <20200116151239.GA253859@mit.edu> References: <20191227080523.31808-1-naoto.kobayashi4c@gmail.com> <20191227080523.31808-3-naoto.kobayashi4c@gmail.com> <20200113223237.GL76141@mit.edu> <20200116123724.GD8446@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116123724.GD8446@quack2.suse.cz> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jan 16, 2020 at 01:37:24PM +0100, Jan Kara wrote: > > Ted, I don't think this patch is needed at all - see my email [1]. Sadly > Naoto didn't reply to my question whether he really saw any deadlock / > lockdep splat or whether it was just a theoretical concern he had... Thanks, good point. So what we should do instead is just drop ext4_kvmalloc() entirely. - Ted