From: Dave Chinner <david@fromorbit.com>
To: ira.weiny@intel.com
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH V5 05/12] fs/xfs: Create function xfs_inode_enable_dax()
Date: Mon, 2 Mar 2020 09:37:45 +1100 [thread overview]
Message-ID: <20200301223745.GE10776@dread.disaster.area> (raw)
In-Reply-To: <20200227052442.22524-6-ira.weiny@intel.com>
On Wed, Feb 26, 2020 at 09:24:35PM -0800, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> xfs_inode_supports_dax() should reflect if the inode can support DAX not
> that it is enabled for DAX.
>
> Change the use of xfs_inode_supports_dax() to reflect only if the inode
> and underlying storage support dax.
>
> Add a new function xfs_inode_enable_dax() which reflects if the inode
> should be enabled for DAX.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>
> ---
> Changes from v3:
> Update functions and names to be more clear
> Update commit message
> Merge with
> 'fs/xfs: Clean up DAX support check'
> don't allow IS_DAX() on a directory
> use STATIC macro for static
> make xfs_inode_supports_dax() static
> ---
> fs/xfs/xfs_iops.c | 25 +++++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 81f2f93caec0..ff711efc5247 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -1237,19 +1237,18 @@ static const struct inode_operations xfs_inline_symlink_inode_operations = {
> };
>
> /* Figure out if this file actually supports DAX. */
> -static bool
> +STATIC bool
> xfs_inode_supports_dax(
> struct xfs_inode *ip)
> {
> struct xfs_mount *mp = ip->i_mount;
>
> /* Only supported on non-reflinked files. */
> - if (!S_ISREG(VFS_I(ip)->i_mode) || xfs_is_reflink_inode(ip))
> + if (xfs_is_reflink_inode(ip))
> return false;
>
> - /* DAX mount option or DAX iflag must be set. */
> - if (!(mp->m_flags & XFS_MOUNT_DAX) &&
> - !(ip->i_d.di_flags2 & XFS_DIFLAG2_DAX))
> + /* Only supported on regular files. */
> + if (!S_ISREG(VFS_I(ip)->i_mode))
> return false;
Why split the initial check? The "non-reflinked files" comment is
pretty explicit, so splitting it just to add a "only support on
regular files" comment doesn't actually add any value here.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-03-01 22:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 5:24 [PATCH V5 00/12] Enable per-file/per-directory DAX operations V5 ira.weiny
2020-02-27 5:24 ` [PATCH V5 01/12] fs/xfs: Remove unnecessary initialization of i_rwsem ira.weiny
2020-02-27 17:25 ` Ira Weiny
2020-02-27 5:24 ` [PATCH V5 02/12] fs: Remove unneeded IS_DAX() check ira.weiny
2020-02-27 5:24 ` [PATCH V5 03/12] fs/stat: Define DAX statx attribute ira.weiny
2020-02-27 5:24 ` [PATCH V5 04/12] fs/xfs: Isolate the physical DAX flag from enabled ira.weiny
2020-02-27 5:24 ` [PATCH V5 05/12] fs/xfs: Create function xfs_inode_enable_dax() ira.weiny
2020-03-01 22:37 ` Dave Chinner [this message]
2020-02-27 5:24 ` [PATCH V5 06/12] fs: Add locking for a dynamic address space operations state ira.weiny
2020-03-02 1:26 ` Dave Chinner
2020-03-02 1:36 ` Dave Chinner
2020-02-27 5:24 ` [PATCH V5 07/12] fs: Prevent DAX state change if file is mmap'ed ira.weiny
2020-02-27 5:24 ` [PATCH V5 08/12] fs/xfs: Hold off aops users while changing DAX state ira.weiny
2020-02-27 5:24 ` [PATCH V5 09/12] fs/xfs: Clean up locking in dax invalidate ira.weiny
2020-02-27 5:24 ` [PATCH V5 10/12] fs/xfs: Allow toggle of effective DAX flag ira.weiny
2020-02-27 5:24 ` [PATCH V5 11/12] fs/xfs: Remove xfs_diflags_to_linux() ira.weiny
2020-02-27 5:24 ` [PATCH V5 12/12] Documentation/dax: Update Usage section ira.weiny
2020-03-05 15:51 ` [PATCH V5 00/12] Enable per-file/per-directory DAX operations V5 Christoph Hellwig
2020-03-09 17:04 ` Ira Weiny
2020-03-11 3:36 ` Darrick J. Wong
2020-03-11 6:29 ` Christoph Hellwig
2020-03-11 17:07 ` Dan Williams
2020-03-16 9:52 ` Jan Kara
2020-03-16 9:55 ` Christoph Hellwig
2020-04-01 4:00 ` Darrick J. Wong
2020-04-01 10:25 ` Jan Kara
2020-04-02 8:53 ` Christoph Hellwig
2020-04-02 20:55 ` Ira Weiny
2020-04-03 7:27 ` Christoph Hellwig
2020-04-03 15:48 ` Ira Weiny
2020-04-03 17:03 ` Jan Kara
2020-04-03 18:18 ` Ira Weiny
2020-04-03 18:21 ` Ira Weiny
2020-04-03 18:37 ` Darrick J. Wong
2020-04-05 6:19 ` Ira Weiny
2020-04-06 10:00 ` Jan Kara
2020-04-03 18:29 ` Darrick J. Wong
2020-04-03 16:05 ` Darrick J. Wong
2020-04-03 4:39 ` Ira Weiny
2020-03-11 6:39 ` Dave Chinner
2020-03-11 6:44 ` Christoph Hellwig
2020-03-11 17:07 ` Dan Williams
2020-03-12 0:49 ` Dave Chinner
2020-03-12 3:00 ` Darrick J. Wong
2020-03-12 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301223745.GE10776@dread.disaster.area \
--to=david@fromorbit.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).