From: Eric Biggers <ebiggers@kernel.org>
To: linux-ext4@vger.kernel.org
Cc: linux-fscrypt@vger.kernel.org
Subject: [PATCH 2/4] tune2fs: prevent stable_inodes feature from being cleared
Date: Wed, 1 Apr 2020 13:32:37 -0700 [thread overview]
Message-ID: <20200401203239.163679-3-ebiggers@kernel.org> (raw)
In-Reply-To: <20200401203239.163679-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
Similar to encrypt and verity, once the stable_inodes feature has been
enabled there may be files anywhere on the filesystem that require this
feature. Therefore, in general it's unsafe to allow clearing it. Don't
allow tune2fs to do so. Like encrypt and verity, it can still be
cleared with debugfs if someone really knows what they're doing.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
misc/tune2fs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index ca06c98b..81f90cbf 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -181,8 +181,7 @@ static __u32 clear_ok_features[3] = {
EXT3_FEATURE_COMPAT_HAS_JOURNAL |
EXT2_FEATURE_COMPAT_RESIZE_INODE |
EXT2_FEATURE_COMPAT_DIR_INDEX |
- EXT4_FEATURE_COMPAT_FAST_COMMIT |
- EXT4_FEATURE_COMPAT_STABLE_INODES,
+ EXT4_FEATURE_COMPAT_FAST_COMMIT,
/* Incompat */
EXT2_FEATURE_INCOMPAT_FILETYPE |
EXT4_FEATURE_INCOMPAT_FLEX_BG |
--
2.26.0.rc2.310.g2932bb562d-goog
next prev parent reply other threads:[~2020-04-01 20:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 20:32 [PATCH 0/4] e2fsprogs: fix and document the stable_inodes feature Eric Biggers
2020-04-01 20:32 ` [PATCH 1/4] tune2fs: prevent changing UUID of fs with " Eric Biggers
2020-04-02 2:19 ` Andreas Dilger
2020-04-07 5:32 ` Eric Biggers
2020-04-07 16:18 ` Andreas Dilger
2020-04-08 3:11 ` Eric Biggers
2020-04-10 11:53 ` Andreas Dilger
2020-04-10 15:06 ` Theodore Y. Ts'o
2020-04-10 16:30 ` Eric Biggers
2020-04-01 20:32 ` Eric Biggers [this message]
2020-04-01 20:32 ` [PATCH 3/4] ext4.5: document the " Eric Biggers
2020-04-01 20:32 ` [PATCH 4/4] tune2fs.8: " Eric Biggers
2020-04-02 2:12 ` Andreas Dilger
2020-04-07 5:10 ` Eric Biggers
2020-04-10 15:24 ` [PATCH 0/4] e2fsprogs: fix and " Theodore Y. Ts'o
2020-05-07 18:18 ` Eric Biggers
2020-06-15 22:22 ` Eric Biggers
2020-07-27 16:45 ` Eric Biggers
2020-09-01 16:19 ` Eric Biggers
2020-09-21 22:41 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401203239.163679-3-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).