From: Jan Kara <jack@suse.cz>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org,
Ritesh Harjani <riteshh@linux.ibm.com>,
Wolfgang Frisch <wolfgang.frisch@suse.com>
Subject: Re: [PATCH 3/4] ext4: Check journal inode extents more carefully
Date: Mon, 27 Jul 2020 12:59:29 +0200 [thread overview]
Message-ID: <20200727105929.GL23179@quack2.suse.cz> (raw)
In-Reply-To: <20200721103855.c5a6ki32ocpe2nwe@work>
On Tue 21-07-20 12:38:55, Lukas Czerner wrote:
> > @@ -270,19 +272,19 @@ int ext4_setup_system_zone(struct super_block *sb)
> > ((i < 5) || ((i % flex_size) == 0)))
> > add_system_zone(system_blks,
> > ext4_group_first_block_no(sb, i),
> > - ext4_bg_num_gdb(sb, i) + 1);
> > + ext4_bg_num_gdb(sb, i) + 1, 0);
>
> Is there a good reason we don't check the return value, it can still
> fail right ?
Yes, it can. I'll add a patch to the series that fixes this.
> Other than that the patch looks good to me.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks for review!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2020-07-27 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 13:18 [PATCH 0/4] ext4: Check journal inode extents more carefully Jan Kara
2020-07-15 13:18 ` [PATCH 1/4] ext4: Handle error of ext4_setup_system_zone() on remount Jan Kara
2020-07-21 10:36 ` Lukas Czerner
2020-07-27 11:02 ` Jan Kara
2020-07-27 11:22 ` Lukas Czerner
2020-07-15 13:18 ` [PATCH 2/4] ext4: Don't allow overlapping system zones Jan Kara
2020-07-21 10:36 ` Lukas Czerner
2020-07-15 13:18 ` [PATCH 3/4] ext4: Check journal inode extents more carefully Jan Kara
2020-07-21 10:38 ` Lukas Czerner
2020-07-27 10:59 ` Jan Kara [this message]
2020-07-15 13:18 ` [PATCH 4/4] ext4: Fold ext4_data_block_valid_rcu() into the caller Jan Kara
2020-07-21 10:39 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727105929.GL23179@quack2.suse.cz \
--to=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=wolfgang.frisch@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).