From: Jan Kara <jack@suse.cz>
To: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: yi.zhang@huawei.com, tytso@mit.edu, jack@suse.cz,
linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca
Subject: Re: [PATCH v2] ext4: Fix bdev write error check failed when mount fs with ro
Date: Fri, 25 Sep 2020 11:10:02 +0200 [thread overview]
Message-ID: <20200925091002.GB11772@quack2.suse.cz> (raw)
In-Reply-To: <20200925010142.3711176-1-zhangxiaoxu5@huawei.com>
On Thu 24-09-20 21:01:42, Zhang Xiaoxu wrote:
> If some errors has occurred on the device, and the orphan list not empty,
> then mount the device with 'ro', the bdev write error check will failed:
> ext4_check_bdev_write_error:193: comm mount: Error while async write back metadata
>
> Since the sbi->s_bdev_wb_err wouldn't be initialized when mount file system
> with 'ro', when clean up the orphan list and access the iloc buffer, bdev
> write error check will failed.
>
> So we should always initialize the sbi->s_bdev_wb_err even if mount the
> file system with 'ro'.
Let me rephrase the changelog a little bit for better readability:
Consider a situation when a filesystem was uncleanly shutdown and the orphan
list is not empty and a read-only mount is attempted. The orphan list
cleanup during mount will fail with:
ext4_check_bdev_write_error:193: comm mount: Error while async write back metadata
This happens because sbi->s_bdev_wb_err is not initialized when mounting
the filesystem in read only mode and so ext4_check_bdev_write_error()
falsely triggers.
Initialize sbi->s_bdev_wb_err unconditionally to avoid this problem.
>
> Fixes: bc71726c7257 ("ext4: abort the filesystem if failed to async write metadata buffer")
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Otherwise the patch looks good so feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index ea425b49b345..0303e6e17190 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4814,9 +4814,8 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> * used to detect the metadata async write error.
> */
> spin_lock_init(&sbi->s_bdev_wb_lock);
> - if (!sb_rdonly(sb))
> - errseq_check_and_advance(&sb->s_bdev->bd_inode->i_mapping->wb_err,
> - &sbi->s_bdev_wb_err);
> + errseq_check_and_advance(&sb->s_bdev->bd_inode->i_mapping->wb_err,
> + &sbi->s_bdev_wb_err);
> sb->s_bdev->bd_super = sb;
> EXT4_SB(sb)->s_mount_state |= EXT4_ORPHAN_FS;
> ext4_orphan_cleanup(sb, es);
> @@ -5707,14 +5706,6 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data)
> goto restore_opts;
> }
>
> - /*
> - * Update the original bdev mapping's wb_err value
> - * which could be used to detect the metadata async
> - * write error.
> - */
> - errseq_check_and_advance(&sb->s_bdev->bd_inode->i_mapping->wb_err,
> - &sbi->s_bdev_wb_err);
> -
> /*
> * Mounting a RDONLY partition read-write, so reread
> * and store the current valid flag. (It may have
> --
> 2.25.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2020-09-25 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 1:01 [PATCH v2] ext4: Fix bdev write error check failed when mount fs with ro Zhang Xiaoxu
2020-09-25 9:10 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925091002.GB11772@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).