linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: 常凤楠 <changfengnan@hikvision.com>,
	changfengnan <changfengnan@qq.com>,
	"adilger@dilger.ca" <adilger@dilger.ca>,
	"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
	"jack@suse.com" <jack@suse.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: 答复: 答复: 答复: [PATCH] jbd2: avoid transaction reuse after reformatting
Date: Sat, 3 Oct 2020 00:24:26 -0400	[thread overview]
Message-ID: <20201003042426.GD23474@mit.edu> (raw)
In-Reply-To: <20200923122435.GG6719@quack2.suse.cz>

On Wed, Sep 23, 2020 at 02:24:35PM +0200, Jan Kara wrote:
> On Wed 23-09-20 06:29:12, 常凤楠 wrote:
> > The attachment is new patch.
> 
> Thanks!
> 
> > I have fix the logic in JBD2_REVOKE_BLOCK and JBD2_COMMIT_BLOCK case.
> > If the revoke block is the first block after valid transaction, I set the
> > flag like descriptor block ,and check it in commit block.  If the commit
> > block is the first block after valid transaction, I use ri_commit_block
> > to judge whether this commit block is next to another commit block, if so
> > it is illegal. I did't use time to judge commit block, because of the
> > possibility of time calibration, I think use ri_commit_block is more
> > reliable.
> 
> If the time is unreliable, your logic with ri_commit_block will detect only
> a small minority of the cases. The majority of cases will fail with
> checksum error. So I still don't think the ri_commit_block logic is really
> worth the additional code. Other than that the current version looks OK to
> me. So please do next submission with full changelog, Signed-off-by line,
> and the coding style issues fixed (you can use scripts/checkpatch.pl for
> patch verification). Thanks!

Hi changfengnan,

Have you had a chance to send a revised patch with the changes
requested by Jan?

Thanks,

					- Ted

      reply	other threads:[~2020-10-03  4:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_2341B065211F204FA07C3ADDA1AE07706405@qq.com>
2020-09-10 12:06 ` [PATCH] jbd2: avoid transaction reuse after reformatting 常凤楠
2020-09-10 18:45 ` Andreas Dilger
2020-09-11 10:06 ` Jan Kara
2020-09-14 11:50   ` 答复: " 常凤楠
2020-09-17 10:44     ` Jan Kara
2020-09-18  1:49       ` 答复: " 常凤楠
2020-09-18 13:02         ` Jan Kara
2020-09-23  6:29           ` 答复: " 常凤楠
2020-09-23 12:24             ` Jan Kara
2020-10-03  4:24               ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201003042426.GD23474@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=changfengnan@hikvision.com \
    --cc=changfengnan@qq.com \
    --cc=darrick.wong@oracle.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).