linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chunguang Xu <brookxu.cn@gmail.com>,
	tytso@mit.edu, adilger.kernel@dilger.ca
Cc: kbuild-all@lists.01.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/8] ext4: use do_div() to calculate block offset
Date: Sat, 17 Oct 2020 10:23:32 +0800	[thread overview]
Message-ID: <202010171020.R3yEBEXz-lkp@intel.com> (raw)
In-Reply-To: <1602820552-4082-3-git-send-email-brookxu@tencent.com>

[-- Attachment #1: Type: text/plain, Size: 3584 bytes --]

Hi Chunguang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.9]
[also build test ERROR on next-20201016]
[cannot apply to ext4/dev tytso-fscrypt/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chunguang-Xu/ext4-use-ASSERT-to-replace-J_ASSERT/20201016-115723
base:    bbf5c979011a099af5dc76498918ed7df445635b
config: arm-cerfcube_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1bcce45cce439ec86a89aa8cfc895b5e9ad5046b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chunguang-Xu/ext4-use-ASSERT-to-replace-J_ASSERT/20201016-115723
        git checkout 1bcce45cce439ec86a89aa8cfc895b5e9ad5046b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/math64.h:7,
                    from include/linux/time.h:6,
                    from fs/ext4/balloc.c:15:
   fs/ext4/balloc.c: In function 'ext4_get_group_desc':
>> arch/arm/include/asm/div64.h:60:36: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types]
      60 | #define do_div(n, base) __div64_32(&(n), base)
         |                                    ^~~~
         |                                    |
         |                                    unsigned int *
   fs/ext4/balloc.c:282:11: note: in expansion of macro 'do_div'
     282 |  offset = do_div(group_desc, EXT4_DESC_PER_BLOCK(sb));
         |           ^~~~~~
   arch/arm/include/asm/div64.h:33:45: note: expected 'uint64_t *' {aka 'long long unsigned int *'} but argument is of type 'unsigned int *'
      33 | static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
         |                                   ~~~~~~~~~~^
   cc1: some warnings being treated as errors

vim +/__div64_32 +60 arch/arm/include/asm/div64.h

fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  53  
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  54  /*
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  55   * In OABI configurations, some uses of the do_div function
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  56   * cause gcc to run out of registers. To work around that,
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  57   * we can force the use of the out-of-line version for
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02  58   * configurations that build a OABI kernel.
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  59   */
040b323b5012b55 arch/arm/include/asm/div64.h Nicolas Pitre 2015-11-02 @60  #define do_div(n, base) __div64_32(&(n), base)
fa4adc614922c24 include/asm-arm/div64.h      Nicolas Pitre 2006-12-06  61  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 13770 bytes --]

  reply	other threads:[~2020-10-17  5:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  3:55 [PATCH 1/8] ext4: use ASSERT() to replace J_ASSERT() Chunguang Xu
2020-10-16  3:55 ` [PATCH 2/8] ext4: remove redundant mb_regenerate_buddy() Chunguang Xu
2020-10-16  3:55 ` [PATCH 3/8] ext4: use do_div() to calculate block offset Chunguang Xu
2020-10-17  2:23   ` kernel test robot [this message]
2020-10-16  3:55 ` [PATCH 4/8] ext4: simplify the code of mb_find_order_for_block Chunguang Xu
2020-10-16  3:55 ` [PATCH 5/8] ext4: add the gdt block of meta_bg to system_zone Chunguang Xu
2020-10-16  3:55 ` [PATCH 6/8] ext4: update ext4_data_block_valid related comments Chunguang Xu
2020-10-16  3:55 ` [PATCH 7/8] ext4: add a helper function to validate metadata block Chunguang Xu
2020-10-16  3:55 ` [PATCH 8/8] ext4: delete invalid code inside ext4_xattr_block_set() Chunguang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202010171020.R3yEBEXz-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=brookxu.cn@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).