From: kernel test robot <lkp@intel.com>
To: Roman Anufriev <dotdot@yandex-team.ru>, linux-ext4@vger.kernel.org
Cc: kbuild-all@lists.01.org, tytso@mit.edu, jack@suse.cz,
dmtrmonakhov@yandex-team.ru, dotdot@yandex-team.ru
Subject: Re: [PATCH v2 2/2] ext4: print quota journalling mode on (re-)mount
Date: Sun, 18 Oct 2020 11:22:44 +0800 [thread overview]
Message-ID: <202010181112.IujKPiIE-lkp@intel.com> (raw)
In-Reply-To: <1602986547-15886-2-git-send-email-dotdot@yandex-team.ru>
[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]
Hi Roman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ext4/dev]
[also build test ERROR on v5.9 next-20201016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Roman-Anufriev/ext4-add-helpers-for-checking-whether-quota-can-be-enabled-is-journalled/20201018-100410
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: i386-randconfig-m021-20201018 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/9ee2e9dad32135b665f733b714c75ff22731bbcd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Roman-Anufriev/ext4-add-helpers-for-checking-whether-quota-can-be-enabled-is-journalled/20201018-100410
git checkout 9ee2e9dad32135b665f733b714c75ff22731bbcd
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ext4/super.c: In function 'ext4_quota_mode':
>> fs/ext4/super.c:3999:19: error: expected ';' before '}' token
3999 | return "disabled"
| ^
| ;
4000 | #endif
4001 | }
| ~
fs/ext4/super.c: In function 'ext4_remount':
fs/ext4/super.c:5738:6: warning: variable 'enable_quota' set but not used [-Wunused-but-set-variable]
5738 | int enable_quota = 0;
| ^~~~~~~~~~~~
vim +3999 fs/ext4/super.c
3987
3988 static const char *ext4_quota_mode(struct super_block *sb)
3989 {
3990 #ifdef CONFIG_QUOTA
3991 if (!ext4_quota_capable(sb))
3992 return "none";
3993
3994 if (ext4_is_quota_journalled(sb))
3995 return "journalled";
3996 else
3997 return "writeback";
3998 #else
> 3999 return "disabled"
4000 #endif
4001 }
4002
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29784 bytes --]
next prev parent reply other threads:[~2020-10-18 3:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 2:02 [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled Roman Anufriev
2020-10-18 2:02 ` [PATCH v2 2/2] ext4: print quota journalling mode on (re-)mount Roman Anufriev
2020-10-18 3:22 ` kernel test robot [this message]
2020-10-19 9:46 ` Roman Anufriev
2020-10-19 9:52 ` Jan Kara
2020-10-22 3:29 ` Roman Anufriev
2020-10-19 9:37 ` [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled Jan Kara
2020-10-19 9:53 ` Jan Kara
2020-10-22 3:33 ` Roman Anufriev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010181112.IujKPiIE-lkp@intel.com \
--to=lkp@intel.com \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=dotdot@yandex-team.ru \
--cc=jack@suse.cz \
--cc=kbuild-all@lists.01.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).