From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/5 v7] ext4: Speedup orphan file handling
Date: Wed, 25 Aug 2021 18:13:31 +0200 [thread overview]
Message-ID: <20210825161331.GA14270@quack2.suse.cz> (raw)
In-Reply-To: <20210825113016.GB14620@quack2.suse.cz>
On Wed 25-08-21 13:30:16, Jan Kara wrote:
> On Tue 24-08-21 13:14:09, Theodore Ts'o wrote:
> > I've been running some tests exercising the orphan_file code, and
> > there are a number of failures:
> >
> > ext4/orphan_file: 512 tests, 3 failures, 25 skipped, 7325 seconds
> > Failures: ext4/044 generic/475 generic/643
> > ext4/orphan_file_1k: 524 tests, 6 failures, 37 skipped, 8361 seconds
> > Failures: ext4/033 ext4/044 ext4/045 generic/273 generic/476 generic/643
So I had a look into the other failures... So ext4/044 works for me after
fixing e2fsck (both in 1k and 4k cases). ext4/033, ext4/045, generic/273
fail for me in the 1k case even without orphan file patches so I don't
think they are a regression caused by my changes (specifically ext4/045 is
a buggy test - I think the directory h-tree is not able to hold that many
directories for 1k block size). Interestingly, I couldn't make generic/476
fail for me either with or without my patches so that may be some random
failure. I'm now running that test in a loop to see whether the failure
will reproduce to investigate.
So overall I don't see any other regressions with my patches (besides that
e2fsck bug). Or did I miss something?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-08-25 16:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 9:57 [PATCH 0/5 v7] ext4: Speedup orphan file handling Jan Kara
2021-08-16 9:57 ` [PATCH 1/5] ext4: Support for checksumming from journal triggers Jan Kara
2021-08-16 9:57 ` [PATCH 2/5] ext4: Move orphan inode handling into a separate file Jan Kara
2021-08-16 9:57 ` [PATCH 3/5] ext4: Speedup ext4 orphan inode handling Jan Kara
2021-08-16 9:57 ` [PATCH 4/5] ext4: Orphan file documentation Jan Kara
2021-08-16 9:57 ` [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling Jan Kara
2021-08-24 17:14 ` [PATCH 0/5 v7] ext4: Speedup " Theodore Ts'o
2021-08-25 11:30 ` Jan Kara
2021-08-25 16:13 ` Jan Kara [this message]
2021-08-25 17:48 ` Theodore Ts'o
2021-08-25 22:13 ` Jan Kara
2021-08-25 22:47 ` Theodore Ts'o
2021-08-26 14:55 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825161331.GA14270@quack2.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).