From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org
Cc: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode()
Date: Tue, 29 Oct 2019 10:20:34 +0300 [thread overview]
Message-ID: <427b6718-0893-0f0f-f5db-5ad45b949a09@yandex-team.ru> (raw)
In-Reply-To: <157233344808.4027.17162642259754563372.stgit@buzz>
On 29/10/2019 10.17, Konstantin Khlebnikov wrote:
> If inode->i_blocks is zero then ext4_evict_inode() skips ext4_truncate().
> Delayed allocation extents are freed later in ext4_clear_inode() but this
> happens when quota reference is already dropped. This leads to leak of
> reserved space in quota block, which disappears after umount-mount.
>
> This seems broken for a long time but worked somehow until recent changes
> in delayed allocation.
FYI, perf cannot correctly parse related perf events without this:
https://lore.kernel.org/lkml/157228145325.7530.4974461761228678289.stgit@buzz/
next prev parent reply other threads:[~2019-10-29 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 7:17 [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode() Konstantin Khlebnikov
2019-10-29 7:20 ` Konstantin Khlebnikov [this message]
2019-11-07 17:58 ` Konstantin Khlebnikov
2019-11-08 2:08 ` Ritesh Harjani
2019-11-08 8:30 ` Konstantin Khlebnikov
2019-11-08 11:54 ` Jan Kara
2019-11-15 0:27 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427b6718-0893-0f0f-f5db-5ad45b949a09@yandex-team.ru \
--to=khlebnikov@yandex-team.ru \
--cc=adilger.kernel@dilger.ca \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).