linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: harshad shirwadkar <harshadshirwadkar@gmail.com>
To: Xu Yihang <xuyihang@huawei.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ext4: fix error return code in ext4_fc_perform_commit()
Date: Thu, 8 Apr 2021 09:26:08 -0700	[thread overview]
Message-ID: <CAD+ocbzHq0rsLvYjtN7YtSPdhTBbs+nJ2RsCR64W-8+WFGWRmQ@mail.gmail.com> (raw)
In-Reply-To: <20210408070033.123047-1-xuyihang@huawei.com>

Thanks, this looks good.

Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

On Thu, Apr 8, 2021 at 12:00 AM Xu Yihang <xuyihang@huawei.com> wrote:
>
> In case of if not ext4_fc_add_tlv branch, an error return code is missing.
>
> Fixes: aa75f4d3daae ("ext4: main fast-commit commit path")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xu Yihang <xuyihang@huawei.com>
> ---
>  fs/ext4/fast_commit.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index 7541d0b5d706..312273ed8a9f 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -1088,8 +1088,10 @@ static int ext4_fc_perform_commit(journal_t *journal)
>                 head.fc_tid = cpu_to_le32(
>                         sbi->s_journal->j_running_transaction->t_tid);
>                 if (!ext4_fc_add_tlv(sb, EXT4_FC_TAG_HEAD, sizeof(head),
> -                       (u8 *)&head, &crc))
> +                       (u8 *)&head, &crc)) {
> +                       ret = -ENOSPC;
>                         goto out;
> +               }
>         }
>
>         spin_lock(&sbi->s_fc_lock);
> --
> 2.17.1
>

  reply	other threads:[~2021-04-08 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  7:00 [PATCH -next] ext4: fix error return code in ext4_fc_perform_commit() Xu Yihang
2021-04-08 16:26 ` harshad shirwadkar [this message]
2021-04-10  1:28 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD+ocbzHq0rsLvYjtN7YtSPdhTBbs+nJ2RsCR64W-8+WFGWRmQ@mail.gmail.com \
    --to=harshadshirwadkar@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=xuyihang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).