linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "cgxu519@zoho.com.cn" <cgxu519@zoho.com.cn>
To: Jan Kara <jack@suse.cz>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: optimize ext2_xattr_get()
Date: Fri, 24 May 2019 10:07:05 +0800	[thread overview]
Message-ID: <afa54281eaf134b892d5f93d281d7ddf75bfe3a5.camel@zoho.com.cn> (raw)
In-Reply-To: <20190523144612.GA18841@quack2.suse.cz>

On Thu, 2019-05-23 at 16:46 +0200, Jan Kara wrote:
> On Tue 21-05-19 16:21:39, Chengguang Xu wrote:
> > Since xattr entry names are sorted, we don't have
> > to continue when current entry name is greater than
> > target.
> > 
> > Signed-off-by: Chengguang Xu <cgxu519@zoho.com.cn>
> 
> Thanks for the patch! If we are going to do these comparisons in multiple
> places, then please create a helper function to do the comparison (so that
> we have the same comparison in every place). Something like:
> 
> int ext2_xattr_cmp(int name_index, size_t name_len, const char *name,
> 		   struct ext2_xattr_entry *entry)
> 

Hi Jan,

Thanks for the review and advice. 

You are right we should introduce a helper to handle this part of work
and personally I think maybe implementing a helper to find target entry
will be more useful, do you think it makes sense?


Thanks,
Chengguang



  reply	other threads:[~2019-05-24  2:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  8:21 [PATCH] ext2: optimize ext2_xattr_get() Chengguang Xu
2019-05-23 14:46 ` Jan Kara
2019-05-24  2:07   ` cgxu519 [this message]
2019-05-24  8:07     ` Jan Kara
2019-05-24  8:58       ` cgxu519

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afa54281eaf134b892d5f93d281d7ddf75bfe3a5.camel@zoho.com.cn \
    --to=cgxu519@zoho.com.cn \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).