From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF06C388F2 for ; Thu, 22 Oct 2020 03:33:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C757521D40 for ; Thu, 22 Oct 2020 03:33:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="og02zOV4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2444081AbgJVDd5 (ORCPT ); Wed, 21 Oct 2020 23:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2443991AbgJVDd5 (ORCPT ); Wed, 21 Oct 2020 23:33:57 -0400 Received: from forwardcorp1p.mail.yandex.net (forwardcorp1p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b6:217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04275C0613CE for ; Wed, 21 Oct 2020 20:33:57 -0700 (PDT) Received: from vla1-fdfb804fb3f3.qloud-c.yandex.net (vla1-fdfb804fb3f3.qloud-c.yandex.net [IPv6:2a02:6b8:c0d:3199:0:640:fdfb:804f]) by forwardcorp1p.mail.yandex.net (Yandex) with ESMTP id 509712E0DB8; Thu, 22 Oct 2020 06:33:54 +0300 (MSK) Received: from vla1-81430ab5870b.qloud-c.yandex.net (vla1-81430ab5870b.qloud-c.yandex.net [2a02:6b8:c0d:35a1:0:640:8143:ab5]) by vla1-fdfb804fb3f3.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id hyUqnPa8Kv-XsxmSpfa; Thu, 22 Oct 2020 06:33:54 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1603337634; bh=UYzaDSpCnGad0qx+ZtxBD8A1Cg/l14jvs8FhdCCfQQ8=; h=Message-ID:In-Reply-To:Subject:To:From:References:Date:cc; b=og02zOV48BNS8Z6qGPbASGtsQMD+4j8aK8IrTMlHkEGU3w9Xcq0gIqh02itke4I3m YQefkrYFs9S2UFTitjdxwD5Q4lcTLaW4d4dTeUeTVUepGoVqTZJi8lJTzd9peOezBD jk7AdgFIpCN3Awz6vC0h5goXCTIshcntvTeVqVug= Authentication-Results: vla1-fdfb804fb3f3.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b081:416::1:0]) by vla1-81430ab5870b.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id XruiuOS3fG-XrnSQb3q; Thu, 22 Oct 2020 06:33:54 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Thu, 22 Oct 2020 06:33:53 +0300 (MSK) From: Roman Anufriev X-X-Sender: dotdot@dotdot-osx To: Jan Kara cc: linux-ext4@vger.kernel.org, tytso@mit.edu, dmtrmonakhov@yandex-team.ru Subject: Re: [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled In-Reply-To: <20201019095328.GE30825@quack2.suse.cz> Message-ID: References: <1602986547-15886-1-git-send-email-dotdot@yandex-team.ru> <20201019093706.GC30825@quack2.suse.cz> <20201019095328.GE30825@quack2.suse.cz> User-Agent: Alpine 2.23 (OSX 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 19 Oct 2020, Jan Kara wrote: > On Mon 19-10-20 11:37:06, Jan Kara wrote: >> On Sun 18-10-20 05:02:26, Roman Anufriev wrote: >>> Right now, there are several places, where we check whether fs is >>> capable of enabling quota or if quota is journalled with quite long >>> and non-self-descriptive condition statements. >>> >>> This patch wraps these statements into helpers for better readability >>> and easier usage. >>> >>> Signed-off-by: Roman Anufriev >> >> Looks good to me. You can add: >> >> Reviewe-by: Jan Kara > > Now I've realized that if we run in nojournal mode, quota won't be > journalled in any case. Probably not a configuration you run in but still > we should get that right. I forgot about this case. Fixed in v4: https://lore.kernel.org/linux-ext4/1603336860-16153-1-git-send-email-dotdot@yandex-team.ru/ Roman