From: Changwei Ge <chge@linux.alibaba.com>
To: Joseph Qi <joseph.qi@linux.alibaba.com>, akpm@linux-foundation.org
Cc: Theodore Ts'o <tytso@mit.edu>,
mark@fasheh.com, jlbec@evilplan.org,
Ross Zwisler <zwisler@google.com>,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com,
gechangwei@live.cn
Subject: Re: [PATCH 2/2] jbd2: remove jbd2_journal_inode_add_[write|wait]
Date: Mon, 15 Jul 2019 11:44:33 +0800 [thread overview]
Message-ID: <eed4b9f4-4afa-ec02-856f-3cc2760654de@linux.alibaba.com> (raw)
In-Reply-To: <1562977611-8412-2-git-send-email-joseph.qi@linux.alibaba.com>
On 2019/7/13 8:26 上午, Joseph Qi wrote:
> Since ext4/ocfs2 are using jbd2_inode dirty range scoping APIs now,
> jbd2_journal_inode_add_[write|wait] are not used any more, remove them.
>
> Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> Reviewed-by: Ross Zwisler <zwisler@google.com>
Acked-by: Changwei Ge <chge@linux.alibaba.com>
> ---
> fs/jbd2/journal.c | 2 --
> fs/jbd2/transaction.c | 12 ------------
> include/linux/jbd2.h | 2 --
> 3 files changed, 16 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 953990e..1c58859 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -89,8 +89,6 @@
> EXPORT_SYMBOL(jbd2_journal_invalidatepage);
> EXPORT_SYMBOL(jbd2_journal_try_to_free_buffers);
> EXPORT_SYMBOL(jbd2_journal_force_commit);
> -EXPORT_SYMBOL(jbd2_journal_inode_add_write);
> -EXPORT_SYMBOL(jbd2_journal_inode_add_wait);
> EXPORT_SYMBOL(jbd2_journal_inode_ranged_write);
> EXPORT_SYMBOL(jbd2_journal_inode_ranged_wait);
> EXPORT_SYMBOL(jbd2_journal_init_jbd_inode);
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 990e7b5..9bf793d 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -2619,18 +2619,6 @@ static int jbd2_journal_file_inode(handle_t *handle, struct jbd2_inode *jinode,
> return 0;
> }
>
> -int jbd2_journal_inode_add_write(handle_t *handle, struct jbd2_inode *jinode)
> -{
> - return jbd2_journal_file_inode(handle, jinode,
> - JI_WRITE_DATA | JI_WAIT_DATA, 0, LLONG_MAX);
> -}
> -
> -int jbd2_journal_inode_add_wait(handle_t *handle, struct jbd2_inode *jinode)
> -{
> - return jbd2_journal_file_inode(handle, jinode, JI_WAIT_DATA, 0,
> - LLONG_MAX);
> -}
> -
> int jbd2_journal_inode_ranged_write(handle_t *handle,
> struct jbd2_inode *jinode, loff_t start_byte, loff_t length)
> {
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index df03825..603fbc4 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1410,8 +1410,6 @@ extern int jbd2_journal_update_sb_log_tail (journal_t *, tid_t,
> extern int jbd2_journal_bmap(journal_t *, unsigned long, unsigned long long *);
> extern int jbd2_journal_force_commit(journal_t *);
> extern int jbd2_journal_force_commit_nested(journal_t *);
> -extern int jbd2_journal_inode_add_write(handle_t *handle, struct jbd2_inode *inode);
> -extern int jbd2_journal_inode_add_wait(handle_t *handle, struct jbd2_inode *inode);
> extern int jbd2_journal_inode_ranged_write(handle_t *handle,
> struct jbd2_inode *inode, loff_t start_byte,
> loff_t length);
next prev parent reply other threads:[~2019-07-15 3:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 0:26 [PATCH 1/2] ocfs2: use jbd2_inode dirty range scoping Joseph Qi
2019-07-13 0:26 ` [PATCH 2/2] jbd2: remove jbd2_journal_inode_add_[write|wait] Joseph Qi
2019-07-15 3:44 ` Changwei Ge [this message]
2019-07-15 3:42 ` [PATCH 1/2] ocfs2: use jbd2_inode dirty range scoping Changwei Ge
2019-07-16 11:15 ` [Ocfs2-devel] " Joseph Qi
2019-07-18 0:54 ` Joseph Qi
2019-07-18 21:25 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2019-07-12 7:02 Joseph Qi
2019-07-12 7:02 ` [PATCH 2/2] jbd2: remove jbd2_journal_inode_add_[write|wait] Joseph Qi
2019-07-12 21:14 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed4b9f4-4afa-ec02-856f-3cc2760654de@linux.alibaba.com \
--to=chge@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=gechangwei@live.cn \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tytso@mit.edu \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).