From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A88FC433FF for ; Sun, 28 Jul 2019 18:50:24 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9789206A2; Sun, 28 Jul 2019 18:50:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="fJrehwQO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="MkxrFdAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9789206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hroFT-00049l-0W; Sun, 28 Jul 2019 18:50:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hroFS-00049c-Hg for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Jul 2019 18:50:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3ux1ayGzH8Mgq3yCNKARU7wNGNJ3ivLh2bizkLSHaN0=; b=fJrehwQOCCKkwkHlzyDXUniubh SmCaHOl0dz79jQ5+xHhasw8c+Q4oHULCOfoQnrER1FaDDqRSA0gEIYQ0rtgOBsSweGYDYG6ff49Eb 6IiuYOebtZHFxRjf/DEKkaqMZRl78byMP5wHnqUuNi6x8s1Vl2TEcUo96/hiZofB4UN4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3ux1ayGzH8Mgq3yCNKARU7wNGNJ3ivLh2bizkLSHaN0=; b=MkxrFdAGOkNsoOSWoHFgGrMgn0 J4CqgEDYtzYp174IsJoatdAJfQW9/PWTDoquLJ4H8n5NXDgHK89xD+7zcuz1A6/4s5zR8/ZLHsKyR GLj/912UJAatDKSKCVOk0s9XCMZy4jsGM9XOtarK/W2V0LyP8WsQhuN/PC1+13MGXdqY=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hroFQ-002B2d-Ag for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Jul 2019 18:50:22 +0000 Received: from callcc.thunk.org (96-72-102-169-static.hfc.comcastbusiness.net [96.72.102.169] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x6SIo4Jb028047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Jul 2019 14:50:05 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 68A2E4202F5; Sun, 28 Jul 2019 14:50:03 -0400 (EDT) Date: Sun, 28 Jul 2019 14:50:03 -0400 From: "Theodore Y. Ts'o" To: Eric Biggers Message-ID: <20190728185003.GF6088@mit.edu> References: <20190726224141.14044-1-ebiggers@kernel.org> <20190726224141.14044-7-ebiggers@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190726224141.14044-7-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1hroFQ-002B2d-Ag Subject: Re: [f2fs-dev] [PATCH v7 06/16] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Satya Tangirala , linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Jul 26, 2019 at 03:41:31PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Add a new fscrypt ioctl, FS_IOC_ADD_ENCRYPTION_KEY. This ioctl adds an > encryption key to the filesystem's fscrypt keyring ->s_master_keys, > making any files encrypted with that key appear "unlocked". Note: it think it's going to be useful to make the keyring id available someplace like /sys/fs///keyring, or preferably in the new fsinfo system call. Yes, the system administrator can paw through /proc/keys and try to figure it out, but it will be nicer if there's a direct way to do that. For that matter, we could just add a new ioctl which returns the file system's keyring id. That way an application program won't have to try to figure out what a file's underlying sb->s_id happens to be. (Especially if things like overlayfs are involved.) > diff --git a/include/uapi/linux/fscrypt.h b/include/uapi/linux/fscrypt.h > index 29a945d165def..93d6eabaa7de4 100644 > --- a/include/uapi/linux/fscrypt.h > +++ b/include/uapi/linux/fscrypt.h > + > +struct fscrypt_key_specifier { > +#define FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR 1 > + __u32 type; > + __u32 __reserved; Can you move the definition of FSCRYPT_KEY_SPEC_TYPE_DESCRIPTOR outside of the structure definition, and then add a comment about what is a "descriptor" key spec? (And then in a later patch, please add a comment about what is an "identifier" key type.) There's an explanation in Documentation/filesystems/fscrypt.rst, I know, but a one or two line comment plus a pointer to Documentation/filesystems/fscrypt.rst in the header file would be really helpful. Otherwise, it looks good. Feel free to add: Reviewed-by: Theodore Ts'o - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel