From: Surbhi Palande <f2fsnewbie@gmail.com>
To: linux-f2fs-devel@lists.sourceforge.net
Cc: Surbhi Palande <csurbhi@gmail.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [f2fs-dev] [PATCH] Return valid segment type in 4 head logging
Date: Wed, 7 Aug 2019 13:54:28 -0700 [thread overview]
Message-ID: <20190807205428.3454-1-csurbhi@gmail.com> (raw)
The valid type of current segments in a 4 head logging scheme are:
CURSEG_HOT_DATA, CURSEG_COLD_DATA
CURSEG_HOT_NODE, CURSEG_HOT_NODE.
When a direct node page is not explicitly marked cold,
return CURSEG_HOT_NODE as it's segment type.
CURSEG_WARM_NODE is not a valid segment type in a
4 head logging scheme.
Signed-off-by: Surbhi Palande <csurbhi@gmail.com>
---
fs/f2fs/segment.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index a661ac32e829..b904b5d7b4df 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -3006,8 +3006,8 @@ static int __get_segment_type_4(struct f2fs_io_info *fio)
else
return CURSEG_COLD_DATA;
} else {
- if (IS_DNODE(fio->page) && is_cold_node(fio->page))
- return CURSEG_WARM_NODE;
+ if (IS_DNODE(fio->page) && !is_cold_node(fio->page))
+ return CURSEG_HOT_NODE;
else
return CURSEG_COLD_NODE;
}
--
2.20.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2019-08-07 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 20:54 Surbhi Palande [this message]
2019-08-08 1:33 ` [f2fs-dev] [PATCH] Return valid segment type in 4 head logging Chao Yu
[not found] ` <CAMBkX3eyb9qNMeoRyNsVg5W=BkChe9Ac2YvW5a7cji8AWvrN=w@mail.gmail.com>
2019-08-08 6:20 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807205428.3454-1-csurbhi@gmail.com \
--to=f2fsnewbie@gmail.com \
--cc=csurbhi@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).