From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive()
Date: Fri, 6 Sep 2019 16:48:08 -0700 [thread overview]
Message-ID: <20190906234808.GC71848@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <20190906105426.109151-1-yuchao0@huawei.com>
On 09/06, Chao Yu wrote:
> If inode is newly created, inode page may not synchronize with inode cache,
> so fields like .i_inline or .i_extra_isize could be wrong, in below call
> path, we may access such wrong fields, result in failing to migrate valid
> target block.
If data is valid, how can we get new inode page?
>
> - gc_data_segment
> - is_alive
> - datablock_addr
> - offset_in_addr
>
> Fixes: 7a2af766af15 ("f2fs: enhance on-disk inode structure scalability")
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/dir.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 765f13354d3f..b1840852967e 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -479,6 +479,9 @@ struct page *f2fs_init_inode_metadata(struct inode *inode, struct inode *dir,
> if (IS_ERR(page))
> return page;
>
> + /* synchronize inode page's data from inode cache */
> + f2fs_update_inode(inode, page);
> +
> if (S_ISDIR(inode->i_mode)) {
> /* in order to handle error case */
> get_page(page);
> --
> 2.18.0.rc1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-09-06 23:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 10:54 [f2fs-dev] [PATCH] f2fs: fix to avoid accessing uninitialized field of inode page in is_alive() Chao Yu
2019-09-06 23:48 ` Jaegeuk Kim [this message]
2019-09-07 1:23 ` Chao Yu
2019-09-09 7:44 ` Jaegeuk Kim
2019-09-09 7:58 ` Chao Yu
2019-09-09 8:16 ` Chao Yu
2019-09-09 8:37 ` Jaegeuk Kim
2019-09-09 9:18 ` Chao Yu
2019-09-09 9:33 ` Jaegeuk Kim
2019-09-09 11:05 ` Chao Yu
2019-09-09 14:37 ` Jaegeuk Kim
2019-09-10 0:59 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906234808.GC71848@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).