From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: ira.weiny@intel.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-xfs@vger.kernel.org, Chris Mason <clm@fb.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-f2fs-devel@lists.sourceforge.net,
Trond Myklebust <trond.myklebust@hammerspace.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] Documentation/fs: Move swap_[de]activate() to file_operations
Date: Thu, 14 Nov 2019 16:28:07 -0800 [thread overview]
Message-ID: <20191115002807.GN6219@magnolia> (raw)
In-Reply-To: <20191114231943.11220-1-ira.weiny@intel.com>
On Thu, Nov 14, 2019 at 03:19:43PM -0800, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> Update the documentation for the move of the swap_* functions out of
> address_space_operations and into file_operations.
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> Follow on to the V2 series sent earlier. If I need to spin a V3 I will squash
> this into patch 2/2 "fs: Move swap_[de]activate to file_operations"
>
> Documentation/filesystems/vfs.rst | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> index 7d4d09dd5e6d..03a740d7faa4 100644
> --- a/Documentation/filesystems/vfs.rst
> +++ b/Documentation/filesystems/vfs.rst
> @@ -731,8 +731,6 @@ cache in your filesystem. The following members are defined:
> unsigned long);
> void (*is_dirty_writeback) (struct page *, bool *, bool *);
> int (*error_remove_page) (struct mapping *mapping, struct page *page);
> - int (*swap_activate)(struct file *);
> - int (*swap_deactivate)(struct file *);
> };
>
> ``writepage``
> @@ -924,16 +922,6 @@ cache in your filesystem. The following members are defined:
> Setting this implies you deal with pages going away under you,
> unless you have them locked or reference counts increased.
>
> -``swap_activate``
> - Called when swapon is used on a file to allocate space if
> - necessary and pin the block lookup information in memory. A
> - return value of zero indicates success, in which case this file
> - can be used to back swapspace.
> -
> -``swap_deactivate``
> - Called during swapoff on files where swap_activate was
> - successful.
> -
>
> The File Object
> ===============
> @@ -988,6 +976,8 @@ This describes how the VFS can manipulate an open file. As of kernel
> struct file *file_out, loff_t pos_out,
> loff_t len, unsigned int remap_flags);
> int (*fadvise)(struct file *, loff_t, loff_t, int);
> + int (*swap_activate)(struct file *);
> + int (*swap_deactivate)(struct file *);
> };
>
> Again, all methods are called without any locks being held, unless
> @@ -1108,6 +1098,16 @@ otherwise noted.
> ``fadvise``
> possibly called by the fadvise64() system call.
>
> +``swap_activate``
> + Called when swapon is used on a file to allocate space if
> + necessary and pin the block lookup information in memory. A
> + return value of zero indicates success, in which case this file
> + can be used to back swapspace.
> +
> +``swap_deactivate``
> + Called during swapoff on files where swap_activate was
> + successful.
> +
> Note that the file operations are implemented by the specific
> filesystem in which the inode resides. When opening a device node
> (character or block special) most filesystems will call special
> --
> 2.21.0
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-15 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 23:19 [f2fs-dev] [PATCH] Documentation/fs: Move swap_[de]activate() to file_operations ira.weiny
2019-11-15 0:28 ` Darrick J. Wong [this message]
2019-11-15 8:44 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115002807.GN6219@magnolia \
--to=darrick.wong@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=ira.weiny@intel.com \
--cc=jaegeuk@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).