From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>, g@linux.intel.com
Cc: Paul Lawrence <paullawrence@google.com>,
David Howells <dhowells@redhat.com>,
Ondrej Mosnacek <omosnace@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org,
linux-mtd@lists.infradead.org, Ondrej Kozina <okozina@redhat.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org, Paul Crowley <paulcrowley@google.com>
Subject: Re: [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY
Date: Mon, 18 Nov 2019 20:05:16 +0200 [thread overview]
Message-ID: <20191118180516.GD5984@linux.intel.com> (raw)
In-Reply-To: <20191118180222.GC5984@linux.intel.com>
On Mon, Nov 18, 2019 at 08:02:22PM +0200, Jarkko Sakkinen wrote:
> On Fri, Nov 15, 2019 at 07:01:39PM -0500, Theodore Y. Ts'o wrote:
> > On Sat, Nov 16, 2019 at 12:53:19AM +0200, Jarkko Sakkinen wrote:
> > > > I'm working on an xfstest for this:
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97
> > > >
> > > > It's not quite ready, though. I'll post it for review when it is.
> > > >
> > > > Someone is also planning to update Android userspace to use this. So if there
> > > > are any issues from that, I'll hear about it.
> > >
> > > Cool. Can you combine this patch and matching test (once it is done) to
> > > a patch set?
> >
> > That's generally not done since the test goes to a different repo
> > (xfstests.git) which has a different review process from the kernel
> > change.
>
> OK, sorry, both fscrypt and xfstests are both somewhat alien to me. That
> is why I'm looking into setting up test environment so that I can review
> these patches with a sane judgement.
And also since I've just barely started to help David on co-maintaining
keyring it is better to put extra emphasis on testing even for the most
trivial patches. That is fastest way to learn different interactions.
/Jarkko
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-18 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 0:12 [f2fs-dev] [PATCH] fscrypt: support passing a keyring key to FS_IOC_ADD_ENCRYPTION_KEY Eric Biggers
2019-11-13 20:35 ` Eric Biggers
2019-11-15 17:29 ` Jarkko Sakkinen
2019-11-15 17:28 ` Jarkko Sakkinen
2019-11-15 19:22 ` Eric Biggers
2019-11-15 22:53 ` Jarkko Sakkinen
2019-11-15 23:04 ` Eric Biggers
2019-11-18 18:01 ` Jarkko Sakkinen
2019-11-18 18:14 ` Eric Biggers
2019-11-16 0:01 ` Theodore Y. Ts'o
2019-11-17 21:44 ` Darrick J. Wong
2019-11-18 18:02 ` Jarkko Sakkinen
2019-11-18 18:05 ` Jarkko Sakkinen [this message]
2019-11-18 18:27 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118180516.GD5984@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=g@linux.intel.com \
--cc=jaegeuk@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=okozina@redhat.com \
--cc=omosnace@redhat.com \
--cc=paulcrowley@google.com \
--cc=paullawrence@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).