From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA59C2BB1D for ; Wed, 15 Apr 2020 01:34:31 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A81B32051A; Wed, 15 Apr 2020 01:34:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="XWvKhqKp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="hJBO1I9k"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="trHGKNCx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A81B32051A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jOWwe-0007WR-KV; Wed, 15 Apr 2020 01:34:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jOWwc-0007WI-SB for linux-f2fs-devel@lists.sourceforge.net; Wed, 15 Apr 2020 01:34:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:Mime-Version :References:In-Reply-To:Message-Id:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jQeXrHMSB4muOGa9bIWb5FzCcoGTEEOSoGfj3H++h3E=; b=XWvKhqKpkyn0uIx0gLOkM4DG7n Y0p/q7AGQvl51cu4aizEKn6FXRGCAOPsh/YFU6gPp8ESTduQ9II8x7gVbQ6XSyGq6zEZYWWGK32Xt CYiPiuRJQiXRq3/QOkqAdFRJv36KSUJ+QJJTWOFpvEvXyAZIG8aWiYwre6FkXzwpFbJ0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:Mime-Version:References: In-Reply-To:Message-Id:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jQeXrHMSB4muOGa9bIWb5FzCcoGTEEOSoGfj3H++h3E=; b=hJBO1I9k0HWMDkUcKZjd08/wyq RmsmIL4QTUGY99E7w4oPT6yNMO7krZ2RnV1XMV5BajeGXke6EYhsG/r5ybIncWrWIubZopz3MYRbM BC0aEQbmpf7TPptzJ8yhz6JoX/CBkIfloZpqsf+iABzwM1un8gN5V48tCUGNtZPxlW6o=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jOWwb-00FQpF-H6 for linux-f2fs-devel@lists.sourceforge.net; Wed, 15 Apr 2020 01:34:26 +0000 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CD58206D9; Wed, 15 Apr 2020 01:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586913426; bh=Z8t12Kri4dLkYoQfBj9LeTBHSVbJC29k8QLFe4WYAn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=trHGKNCxzakSMiiFFW7h7ipr5l5ZPqXMRMACUtk4YKpwd8Pg1RJ2PiBsRP5nCE9+1 fCvzyZDvGOZsZH+JWcOhF2bmZOk4UdQ9IgBloKo9E4jlYJXAc0OSn746DXLsWt7WBJ s1ct6x0rSpHRCfj/HRWtfY1TDdkeieGLLTsLzoWE= Date: Tue, 14 Apr 2020 18:17:05 -0700 From: Andrew Morton To: Matthew Wilcox Message-Id: <20200414181705.bfc4c0087092051a9475141e@linux-foundation.org> In-Reply-To: <20200414150233.24495-6-willy@infradead.org> References: <20200414150233.24495-1-willy@infradead.org> <20200414150233.24495-6-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Headers-End: 1jOWwb-00FQpF-H6 Subject: Re: [f2fs-dev] [PATCH v11 05/25] mm: Add new readahead_control API X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, William Kucharski , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, 14 Apr 2020 08:02:13 -0700 Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Filesystems which implement the upcoming ->readahead method will get > their pages by calling readahead_page() or readahead_page_batch(). > These functions support large pages, even though none of the filesystems > to be converted do yet. > > +static inline struct page *readahead_page(struct readahead_control *rac) > +static inline unsigned int __readahead_batch(struct readahead_control *rac, > + struct page **array, unsigned int array_sz) These are large functions. Was it correct to inline them? The batching API only appears to be used by fuse? If so, do we really need it? Does it provide some functional need, or is it a performance thing? If the latter, how significant is it? The code adds quite a few (inlined!) VM_BUG_ONs. Can we plan to remove them at some stage? Such as, before Linus shouts at us :) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel