From: Johannes Weiner <hannes@cmpxchg.org>
To: Hugh Dickins <hughd@google.com>
Cc: lkft-triage@lists.linaro.org, Michal Hocko <mhocko@kernel.org>,
linux-mm <linux-mm@kvack.org>, Yafang Shao <laoar.shao@gmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Cgroups <cgroups@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Anders Roxell <anders.roxell@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Matthew Wilcox <willy@infradead.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-block <linux-block@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Chris Down <chris@chrisdown.name>,
open list <linux-kernel@vger.kernel.org>,
"Linux F2FS DEV,
Mailing List" <linux-f2fs-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>
Subject: Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page
Date: Thu, 21 May 2020 17:58:55 -0400 [thread overview]
Message-ID: <20200521215855.GB815153@cmpxchg.org> (raw)
In-Reply-To: <alpine.LSU.2.11.2005211250130.1158@eggly.anvils>
On Thu, May 21, 2020 at 01:06:28PM -0700, Hugh Dickins wrote:
> On Thu, 21 May 2020, Johannes Weiner wrote:
> > do_memsw_account() used to be automatically false when the cgroup
> > controller was disabled. Now that it's replaced by
> > cgroup_memory_noswap, for which this isn't true, make the
> > mem_cgroup_disabled() checks explicit in the swap control API.
> >
> > [hannes@cmpxchg.org: use mem_cgroup_disabled() in all API functions]
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Debugged-by: Hugh Dickins <hughd@google.com>
> > Debugged-by: Michal Hocko <mhocko@kernel.org>
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > ---
> > mm/memcontrol.c | 47 +++++++++++++++++++++++++++++++++++++++++------
> > 1 file changed, 41 insertions(+), 6 deletions(-)
>
> I'm certainly not against a mem_cgroup_disabled() check in the only
> place that's been observed to need it, as a fixup to merge into your
> original patch; but this seems rather an over-reaction - and I'm a
> little surprised that setting mem_cgroup_disabled() doesn't just
> force cgroup_memory_noswap, saving repetitious checks elsewhere
> (perhaps there's a difficulty in that, I haven't looked).
Fair enough, I changed it to set the flag at initialization time if
mem_cgroup_disabled(). I was never a fan of the old flags, where it
was never clear what was commandline, and what was internal runtime
state - do_swap_account? really_do_swap_account? But I think it's
straight-forward in this case now.
> Historically, I think we've added mem_cgroup_disabled() checks
> (accessing a cacheline we'd rather avoid) where they're necessary,
> rather than at every "interface".
To me that always seemed like bugs waiting to happen. Like this one!
It's a jump label nowadays, so I've been liberal with these to avoid
subtle bugs.
> And you seem to be in a very "goto out" mood today - we all have
> our "goto out" days, alternating with our "return 0" days :)
:-)
But I agree, best to keep this fixup self-contained and defer anything
else to separate cleanup patches.
How about the below? It survives a swaptest with cgroup_disable=memory
for me.
Hugh, I started with your patch, which is why I kept you as the
author, but as the patch now (and arguably the previous one) is
sufficiently different, I dropped that now. I hope that's okay.
---
From d9e7ed15d1c9248a3fd99e35e82437549154dac7 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <hannes@cmpxchg.org>
Date: Thu, 21 May 2020 17:44:25 -0400
Subject: [PATCH] mm: memcontrol: prepare swap controller setup for integration
fix
Fix crash with cgroup_disable=memory:
> > > > + mkfs -t ext4 /dev/disk/by-id/ata-TOSHIBA_MG04ACA100N_Y8NRK0BPF6XF
> > > > mke2fs 1.43.8 (1-Jan-2018)
> > > > Creating filesystem with 244190646 4k blocks and 61054976 inodes
> > > > Filesystem UUID: 3bb1a285-2cb4-44b4-b6e8-62548f3ac620
> > > > Superblock backups stored on blocks:
> > > > 32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208,
> > > > 4096000, 7962624, 11239424, 20480000, 23887872, 71663616, 78675968,
> > > > 102400000, 214990848
> > > > Allocating group tables: 0/7453 done
> > > > Writing inode tables: 0/7453 done
> > > > Creating journal (262144 blocks): [ 35.502102] BUG: kernel NULL
> > > > pointer dereference, address: 000000c8
> > > > [ 35.508372] #PF: supervisor read access in kernel mode
> > > > [ 35.513506] #PF: error_code(0x0000) - not-present page
> > > > [ 35.518638] *pde = 00000000
> > > > [ 35.521514] Oops: 0000 [#1] SMP
> > > > [ 35.524652] CPU: 0 PID: 145 Comm: kswapd0 Not tainted
> > > > 5.7.0-rc6-next-20200519+ #1
> > > > [ 35.532121] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
> > > > 2.2 05/23/2018
> > > > [ 35.539507] EIP: mem_cgroup_get_nr_swap_pages+0x28/0x60
Swap accounting used to be implied-disabled when the cgroup controller
was disabled. Restore that for the new cgroup_memory_noswap, so that
we bail out of this function instead of dereferencing a NULL memcg.
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Debugged-by: Hugh Dickins <hughd@google.com>
Debugged-by: Michal Hocko <mhocko@kernel.org>
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
mm/memcontrol.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 3e000a316b59..e3b785d6e771 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7075,7 +7075,11 @@ static struct cftype memsw_files[] = {
static int __init mem_cgroup_swap_init(void)
{
- if (mem_cgroup_disabled() || cgroup_memory_noswap)
+ /* No memory control -> no swap control */
+ if (mem_cgroup_disabled())
+ cgroup_memory_noswap = true;
+
+ if (cgroup_memory_noswap)
return 0;
WARN_ON(cgroup_add_dfl_cftypes(&memory_cgrp_subsys, swap_files));
--
2.26.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-21 21:59 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 12:38 [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Naresh Kamboju
2020-05-01 20:58 ` Andrew Morton
2020-05-18 14:10 ` Naresh Kamboju
2020-05-19 7:52 ` Michal Hocko
2020-05-19 8:11 ` Arnd Bergmann
2020-05-19 8:45 ` Michal Hocko
2020-05-20 11:56 ` Naresh Kamboju
2020-05-20 17:59 ` Naresh Kamboju
2020-05-20 19:09 ` Chris Down
2020-05-21 9:22 ` Naresh Kamboju
2020-05-21 9:35 ` Arnd Bergmann
2020-05-21 9:55 ` Michal Hocko
2020-05-21 10:41 ` Naresh Kamboju
2020-05-21 10:58 ` Michal Hocko
2020-05-21 12:24 ` Hugh Dickins via Linux-f2fs-devel
2020-05-21 12:44 ` Michal Hocko
2020-05-21 19:17 ` Johannes Weiner
2020-05-21 20:06 ` Hugh Dickins via Linux-f2fs-devel
2020-05-21 21:58 ` Johannes Weiner [this message]
2020-05-21 23:35 ` Hugh Dickins via Linux-f2fs-devel
2020-05-28 14:59 ` Michal Hocko
2020-05-21 16:34 ` Michal Hocko
2020-05-21 19:00 ` Naresh Kamboju
2020-05-21 20:53 ` Naresh Kamboju
2020-05-28 15:03 ` Michal Hocko
2020-05-28 16:17 ` Naresh Kamboju
2020-05-28 16:41 ` Chris Down
2020-05-29 1:50 ` Yafang Shao
2020-05-29 1:56 ` Chris Down
2020-05-29 9:49 ` Michal Hocko
2020-06-11 9:55 ` Michal Hocko
2020-06-12 9:43 ` Naresh Kamboju
2020-06-12 12:09 ` Michal Hocko
2020-06-17 13:37 ` Naresh Kamboju
2020-06-17 13:57 ` Chris Down
2020-06-17 14:11 ` Michal Hocko
2020-06-17 15:53 ` Naresh Kamboju
2020-06-17 16:06 ` Michal Hocko
2020-06-17 20:13 ` Naresh Kamboju
2020-06-17 21:09 ` Chris Down
2020-06-18 1:43 ` Yafang Shao
2020-06-18 12:37 ` Chris Down
2020-06-18 12:41 ` Michal Hocko
2020-06-18 12:49 ` Chris Down
2020-06-18 14:59 ` Yafang Shao
2020-06-17 13:59 ` Michal Hocko
2020-06-17 14:08 ` Chris Down
2020-05-21 2:39 ` Yafang Shao
2020-05-21 8:58 ` Naresh Kamboju
2020-05-21 9:47 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521215855.GB815153@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hughd@google.com \
--cc=jaegeuk@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mhocko@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).