From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, Theodore Ts'o <tytso@mit.edu>,
Jonathan Corbet <corbet@lwn.net>,
Richard Weinberger <richard@nod.at>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches
Date: Tue, 23 Jun 2020 22:34:58 -0700 [thread overview]
Message-ID: <20200624053458.GD844@sol.localdomain> (raw)
In-Reply-To: <20200624043341.33364-1-drosen@google.com>
On Tue, Jun 23, 2020 at 09:33:37PM -0700, Daniel Rosenberg wrote:
> This lays the ground work for enabling casefolding and encryption at the
> same time for ext4 and f2fs. A future set of patches will enable that
> functionality. These unify the highly similar dentry_operations that ext4
> and f2fs both use for casefolding.
I think this undersells this patchset a bit. This patchset makes ext4 and f2fs
share the casefolded ->d_compare() and ->d_hash() implementations, which
eliminates duplicated code. That's a good thing regardless of whether we're
going to add encrypt+casefold support or not.
It also changes the casefolded ->d_hash() implementation to not have to allocate
memory (with GFP_ATOMIC, no less), which was a big problem with the old
implementation as it's unreliable and inefficient.
So yes, this prepares for supporting encrypt+casefold. But these changes make
sense on their own too as an improvement of the casefold feature. Except for
the one line of code in needs_casefold() that is specific to encrypt+casefold;
maybe that should be left out for now.
(Side note: I think you could drop linux-doc and linux-mtd from Cc, as this
patchset isn't really relevant to those mailing lists.)
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2020-06-24 5:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 4:33 [f2fs-dev] [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 4:33 ` [f2fs-dev] [PATCH v9 1/4] unicode: Add utf8_casefold_hash Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 5:13 ` Gabriel Krisman Bertazi
2020-06-24 5:37 ` Eric Biggers
2020-06-24 4:33 ` [f2fs-dev] [PATCH v9 2/4] fs: Add standard casefolding support Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 5:33 ` Gabriel Krisman Bertazi
2020-06-24 5:42 ` Eric Biggers
2020-06-24 5:57 ` Eric Biggers
2020-07-03 1:01 ` Daniel Rosenberg via Linux-f2fs-devel
2020-07-03 19:20 ` Eric Biggers
2020-06-24 4:33 ` [f2fs-dev] [PATCH v9 3/4] f2fs: Use generic " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 4:33 ` [f2fs-dev] [PATCH v9 4/4] ext4: " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 5:43 ` Gabriel Krisman Bertazi
2020-07-07 10:44 ` Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 6:04 ` Eric Biggers
2020-06-24 5:34 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624053458.GD844@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).