From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: make fibmap consistent with fiemap for compression chunk
Date: Sun, 30 Aug 2020 07:44:09 +0800 [thread overview]
Message-ID: <44f8d9f3-9438-fdfe-bbc3-f5347a9aaa29@kernel.org> (raw)
In-Reply-To: <20200828034953.354267-1-daeho43@gmail.com>
On 2020-8-28 11:49, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Currently fibmap returns zero address for compression chunk. But it
> is not consistent with the output of fiemap, since fiemap returns
> real pysical block address related to the compression chunk. Therefore
> I suggest fibmap returns the same output with fiemap.
We can return real physical block address in fiemap, because we have set
FIEMAP_EXTENT_ENCODED flag in extent.fe_flags, then user can be noticed that he
can not just read/write that block address for access/update in-there data.
Quoted from Documentation/filesystems/fiemap.rst
"
FIEMAP_EXTENT_ENCODED
This extent does not consist of plain filesystem blocks but is
encoded (e.g. encrypted or compressed). Reading the data in this
extent via I/O to the block device will have undefined results.
"
However, there is no such flag in fibmap interface, so I just return block
address for those logical pages in non-compressed cluster.
Thanks,
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> fs/f2fs/data.c | 33 ---------------------------------
> 1 file changed, 33 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index c1b676be67b9..8c26c5d0c778 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3708,36 +3708,6 @@ static int f2fs_set_data_page_dirty(struct page *page)
> return 0;
> }
>
> -
> -static sector_t f2fs_bmap_compress(struct inode *inode, sector_t block)
> -{
> -#ifdef CONFIG_F2FS_FS_COMPRESSION
> - struct dnode_of_data dn;
> - sector_t start_idx, blknr = 0;
> - int ret;
> -
> - start_idx = round_down(block, F2FS_I(inode)->i_cluster_size);
> -
> - set_new_dnode(&dn, inode, NULL, NULL, 0);
> - ret = f2fs_get_dnode_of_data(&dn, start_idx, LOOKUP_NODE);
> - if (ret)
> - return 0;
> -
> - if (dn.data_blkaddr != COMPRESS_ADDR) {
> - dn.ofs_in_node += block - start_idx;
> - blknr = f2fs_data_blkaddr(&dn);
> - if (!__is_valid_data_blkaddr(blknr))
> - blknr = 0;
> - }
> -
> - f2fs_put_dnode(&dn);
> - return blknr;
> -#else
> - return 0;
> -#endif
> -}
> -
> -
> static sector_t f2fs_bmap(struct address_space *mapping, sector_t block)
> {
> struct inode *inode = mapping->host;
> @@ -3753,9 +3723,6 @@ static sector_t f2fs_bmap(struct address_space *mapping, sector_t block)
> if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY))
> filemap_write_and_wait(mapping);
>
> - if (f2fs_compressed_file(inode))
> - blknr = f2fs_bmap_compress(inode, block);
> -
> if (!get_data_block_bmap(inode, block, &tmp, 0))
> blknr = tmp.b_blocknr;
> out:
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-08-29 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 3:49 [f2fs-dev] [PATCH] f2fs: make fibmap consistent with fiemap for compression chunk Daeho Jeong
2020-08-29 23:44 ` Chao Yu [this message]
2020-08-30 23:36 ` Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f8d9f3-9438-fdfe-bbc3-f5347a9aaa29@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).