From: Chao Yu <yuchao0@huawei.com>
To: Sahitya Tummala <stummala@codeaurora.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix long latency due to discard during umount
Date: Tue, 24 Mar 2020 17:08:58 +0800 [thread overview]
Message-ID: <54ae330b-ac9b-7968-fa0a-95db6737e3ea@huawei.com> (raw)
In-Reply-To: <1584506689-5041-1-git-send-email-stummala@codeaurora.org>
On 2020/3/18 12:44, Sahitya Tummala wrote:
> F2FS already has a default timeout of 5 secs for discards that
> can be issued during umount, but it can take more than the 5 sec
> timeout if the underlying UFS device queue is already full and there
> are no more available free tags to be used. In that case, submit_bio()
> will wait for the already queued discard requests to complete to get
> a free tag, which can potentially take way more than 5 sec.
>
> Fix this by submitting the discard requests with REQ_NOWAIT
> flags during umount. This will return -EAGAIN for UFS queue/tag full
> scenario without waiting in the context of submit_bio(). The FS can
> then handle these requests by retrying again within the stipulated
> discard timeout period to avoid long latencies.
>
> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next parent reply other threads:[~2020-03-24 9:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1584506689-5041-1-git-send-email-stummala@codeaurora.org>
2020-03-24 9:08 ` Chao Yu [this message]
2020-03-24 9:47 ` [f2fs-dev] [PATCH] f2fs: fix long latency due to discard during umount Chao Yu
2020-03-26 9:00 ` Chao Yu
2020-03-26 13:37 ` Sahitya Tummala
2020-03-27 1:51 ` Chao Yu
[not found] ` <20200327030542.GS20234@codeaurora.org>
2020-03-30 6:53 ` Sahitya Tummala
2020-03-30 8:38 ` Chao Yu
2020-03-30 10:16 ` Chao Yu
2020-03-30 10:51 ` Sahitya Tummala
2020-03-31 1:46 ` Chao Yu
2020-03-31 3:10 ` Sahitya Tummala
2020-03-31 3:50 ` Jaegeuk Kim
[not found] <1584011671-20939-1-git-send-email-stummala@codeaurora.org>
2020-03-12 17:02 ` Jaegeuk Kim
[not found] ` <20200313012604.GI20234@codeaurora.org>
2020-03-13 1:45 ` Jaegeuk Kim
2020-03-13 5:12 ` Sahitya Tummala
2020-03-13 15:38 ` Jaegeuk Kim
2020-03-13 2:20 ` Chao Yu
[not found] ` <20200313033912.GJ20234@codeaurora.org>
2020-03-13 6:30 ` Chao Yu
[not found] ` <20200313110846.GL20234@codeaurora.org>
2020-03-16 0:52 ` Chao Yu
2020-03-16 3:52 ` Sahitya Tummala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ae330b-ac9b-7968-fa0a-95db6737e3ea@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stummala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).