From: Daniel Rosenberg via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Theodore Ts'o <tytso@mit.edu>, Jonathan Corbet <corbet@lwn.net>,
kernel-team@android.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v3 5/9] vfs: Fold casefolding into vfs
Date: Thu, 23 Jan 2020 20:30:49 -0800 [thread overview]
Message-ID: <CA+PiJmQPFG7OehStFfNQE_7MGwgozhaa0TxZd+aHL2cFLMFbsA@mail.gmail.com> (raw)
In-Reply-To: <20200120013528.GY8904@ZenIV.linux.org.uk>
> ... buggering the filesystems (and boxen) that never planned to use
> that garbage.
>
I'm planning to rework this as dentry ops again. Your other comments
point out some issues that also exist in the old dentry_operations, so
that's a good opportunity to fix those up. How do you feel about just
having the two entries in struct super_block? With them there, I can
add the dentry_operations to fs/unicode where they won't bother anyone
else, while not making every filesystem that uses it have to carry
near identical code.
>
> Are you serious?
> 1) who said that ->d_inode is stable here? If we are in RCU mode,
> it won't be.
> 2) page-sized kmalloc/kfree *ON* *COMPONENT* *AFTER* *COMPONENT*?
>
#2 is the part that made me the saddest in the patch. I'm planning to
move this to the unicode subsystem so it can just walk through the
name as it computes the hash without needing any allocation.
>
> ... and again, you are pulling in a lot of cachelines.
>
I probably should've just given it a DCACHE flag, like what fscrypt is
using. A simple flag there would've done everything that I'm doing
without making the cache super sad and making any attempts at making
it actually work with RCU much simpler.
> <understatement> IMO the whole thing is not a good idea. </understatement>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-01-24 4:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 21:42 [f2fs-dev] [PATCH v3 0/9] Support for Casefolding and Encryption Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 1/9] fscrypt: Add siphash and hash key for policy v2 Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 2/9] fscrypt: Don't allow v1 policies with casefolding Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 3/9] fscrypt: Change format of no-key token Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 4/9] fscrypt: Only create hash key when needed Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 5/9] vfs: Fold casefolding into vfs Daniel Rosenberg via Linux-f2fs-devel
2020-01-20 1:35 ` Al Viro
2020-01-24 4:30 ` Daniel Rosenberg via Linux-f2fs-devel [this message]
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 6/9] f2fs: Handle casefolding with Encryption Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 7/9] ext4: Use struct super_blocks' casefold data Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 8/9] ext4: Hande casefolding with encryption Daniel Rosenberg via Linux-f2fs-devel
2020-01-17 21:42 ` [f2fs-dev] [PATCH v3 9/9] ext4: Optimize match for casefolded encrypted dirs Daniel Rosenberg via Linux-f2fs-devel
2020-01-20 4:52 ` [f2fs-dev] [PATCH v3 0/9] Support for Casefolding and Encryption Eric Biggers
2020-01-20 22:10 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+PiJmQPFG7OehStFfNQE_7MGwgozhaa0TxZd+aHL2cFLMFbsA@mail.gmail.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=adilger.kernel@dilger.ca \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).