From: Chao Yu <yuchao0@huawei.com>
To: Eric Biggers <ebiggers@kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Cc: linux-fscrypt@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
Daniel Rosenberg <drosen@google.com>
Subject: Re: [f2fs-dev] [PATCH 2/4] f2fs: split f2fs_d_compare() from f2fs_match_name()
Date: Mon, 11 May 2020 10:47:07 +0800 [thread overview]
Message-ID: <a6271be8-6296-0fda-b832-ffda6b063338@huawei.com> (raw)
In-Reply-To: <20200507075905.953777-3-ebiggers@kernel.org>
On 2020/5/7 15:59, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Sharing f2fs_ci_compare() between comparing cached dentries
> (f2fs_d_compare()) and comparing on-disk dentries (f2fs_match_name())
> doesn't work as well as intended, as these actions fundamentally differ
> in several ways (e.g. whether the task may sleep, whether the directory
> is stable, whether the casefolded name was precomputed, whether the
> dentry will need to be decrypted once we allow casefold+encrypt, etc.)
>
> Just make f2fs_d_compare() implement what it needs directly, and rework
> f2fs_ci_compare() to be specialized for f2fs_match_name().
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-11 2:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 7:59 [f2fs-dev] [PATCH 0/4] f2fs: rework filename handling Eric Biggers
2020-05-07 7:59 ` [f2fs-dev] [PATCH 1/4] f2fs: don't leak filename in f2fs_try_convert_inline_dir() Eric Biggers
2020-05-08 8:25 ` Chao Yu
2020-05-07 7:59 ` [f2fs-dev] [PATCH 2/4] f2fs: split f2fs_d_compare() from f2fs_match_name() Eric Biggers
2020-05-11 2:47 ` Chao Yu [this message]
2020-05-07 7:59 ` [f2fs-dev] [PATCH 3/4] f2fs: rework filename handling Eric Biggers
2020-05-25 8:12 ` Chao Yu
2020-05-25 15:10 ` Jaegeuk Kim
2020-05-07 7:59 ` [f2fs-dev] [RFC PATCH 4/4] f2fs: Handle casefolding with Encryption (INCOMPLETE) Eric Biggers
2020-05-08 2:55 ` Eric Biggers
2020-05-07 13:09 ` [f2fs-dev] [PATCH 0/4] f2fs: rework filename handling Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6271be8-6296-0fda-b832-ffda6b063338@huawei.com \
--to=yuchao0@huawei.com \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=krisman@collabora.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).