From: Chao Yu <chao@kernel.org>
To: heyunlei <heyunlei@hihonor.com>, jaegeuk@kernel.org
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fsverity: Truncate cache pages if set verity failed
Date: Wed, 24 Feb 2021 21:16:24 +0800 [thread overview]
Message-ID: <c1ce1421-2576-5b48-322c-fa682c7510d7@kernel.org> (raw)
In-Reply-To: <20210223112425.19180-1-heyunlei@hihonor.com>
Hi Yunlei,
On 2021/2/23 19:24, heyunlei wrote:
> If file enable verity failed, should truncate anything wrote
> past i_size, including cache pages.
+Cc Eric,
After failure of enabling verity, we will see verity metadata if we truncate
file to larger size later?
Thanks,
>
> Signed-off-by: heyunlei <heyunlei@hihonor.com>
> ---
> fs/f2fs/verity.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c
> index 054ec852b5ea..f1f9b9361a71 100644
> --- a/fs/f2fs/verity.c
> +++ b/fs/f2fs/verity.c
> @@ -170,8 +170,10 @@ static int f2fs_end_enable_verity(struct file *filp, const void *desc,
> }
>
> /* If we failed, truncate anything we wrote past i_size. */
> - if (desc == NULL || err)
> + if (desc == NULL || err) {
> + truncate_inode_pages(inode->i_mapping, inode->i_size);
> f2fs_truncate(inode);
> + }
>
> clear_inode_flag(inode, FI_VERITY_IN_PROGRESS);
>
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next parent reply other threads:[~2021-02-24 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210223112425.19180-1-heyunlei@hihonor.com>
2021-02-24 13:16 ` Chao Yu [this message]
2021-02-24 23:02 ` [f2fs-dev] [PATCH] f2fs: fsverity: Truncate cache pages if set verity failed Eric Biggers
2021-02-24 23:11 ` Eric Biggers
2021-02-26 1:42 ` heyunlei 00015531
2021-02-26 2:15 ` Eric Biggers
2021-02-28 4:52 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ce1421-2576-5b48-322c-fa682c7510d7@kernel.org \
--to=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=heyunlei@hihonor.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).