From: Chao Yu <yuchao0@huawei.com>
To: Daeho Jeong <daeho43@gmail.com>
Cc: Daeho Jeong <daehojeong@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove race condition in releasing cblocks
Date: Fri, 8 May 2020 15:09:06 +0800 [thread overview]
Message-ID: <cd08c824-c5d3-9603-7a81-a48cb191ac99@huawei.com> (raw)
In-Reply-To: <CACOAw_z0BU3t7V+BN7TvaO96GckwNh2SRLreGxO60EDbMb_epw@mail.gmail.com>
On 2020/5/8 14:58, Daeho Jeong wrote:
> I moved checking i_compr_blocks phrase after calling inode_lock()
> already, because we should check this after writing pages.
>
> So, if it fails to check i_compr_blocks, we need to call inode_unlock().
>
> Am I missing something?
After applying this patch, I get this:
ret = mnt_want_write_file(filp);
if (ret)
return ret;
if (!F2FS_I(inode)->i_compr_blocks)
goto out;
f2fs_balance_fs(F2FS_I_SB(inode), true);
inode_lock(inode);
>
> 2020년 5월 8일 (금) 오후 3:50, Chao Yu <yuchao0@huawei.com>님이 작성:
>>
>> On 2020/5/8 12:25, Daeho Jeong wrote:
>>> From: Daeho Jeong <daehojeong@google.com>
>>>
>>> Now, if writing pages and releasing compress blocks occur
>>> simultaneously, and releasing cblocks is executed more than one time
>>> to a file, then total block count of filesystem and block count of the
>>> file could be incorrect and damaged.
>>>
>>> We have to execute releasing compress blocks only one time for a file
>>> without being interfered by writepages path.
>>>
>>> Signed-off-by: Daeho Jeong <daehojeong@google.com>
>>> ---
>>> fs/f2fs/file.c | 31 ++++++++++++++++++++++++-------
>>> 1 file changed, 24 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>>> index 4aab4b42d8ba..a92bc51b9b28 100644
>>> --- a/fs/f2fs/file.c
>>> +++ b/fs/f2fs/file.c
>>> @@ -3488,6 +3488,7 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
>>> pgoff_t page_idx = 0, last_idx;
>>> unsigned int released_blocks = 0;
>>> int ret;
>>> + int writecount;
>>>
>>> if (!f2fs_sb_has_compression(F2FS_I_SB(inode)))
>>> return -EOPNOTSUPP;
>>
>> Before inode_lock(), there is one case we may jump to out label, in
>> this case, we may unlock inode incorrectly.
>>
>> if (!F2FS_I(inode)->i_compr_blocks)
>> goto out;
>>
>>> -
>>> - inode_unlock(inode);
>>> out:
>>> + inode_unlock(inode);
>>> +
>>> mnt_drop_write_file(filp);
>>
>> Thanks,
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-08 7:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 4:25 [f2fs-dev] [PATCH] f2fs: remove race condition in releasing cblocks Daeho Jeong
2020-05-08 6:50 ` Chao Yu
2020-05-08 6:58 ` Daeho Jeong
2020-05-08 7:09 ` Chao Yu [this message]
2020-05-08 7:10 ` Daeho Jeong
2020-05-08 9:29 Daeho Jeong
2020-05-08 10:09 ` Chao Yu
2020-05-08 13:47 ` Jaegeuk Kim
2020-05-08 11:56 Daeho Jeong
2020-05-08 13:48 ` Jaegeuk Kim
2020-05-08 13:58 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd08c824-c5d3-9603-7a81-a48cb191ac99@huawei.com \
--to=yuchao0@huawei.com \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).