From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [f2fs-dev] [PATCH v2 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer()
Date: Mon, 11 Nov 2019 07:56:12 +0100 [thread overview]
Message-ID: <e5d0a5c6-0a6e-fea9-0d19-42b42bb63499@suse.de> (raw)
In-Reply-To: <20191111023930.638129-9-damien.lemoal@wdc.com>
On 11/11/19 3:39 AM, Damien Le Moal wrote:
> There is no need to arbitrarily limit the size of a report zone to the
> number of zones defined by SD_ZBC_REPORT_MAX_ZONES. Rather, simply
> calculate the report buffer size needed for the requested number of
> zones without exceeding the device total number of zones. This buffer
> size limitation to the hardware maximum transfer size and page mapping
> capabilities is kept unchanged. Starting with this initial buffer size,
> the allocation is optimized by iterating over decreasing buffer size
> until the allocation succeeds (each iteration is allowed to fail fast
> using the __GFP_NORETRY flag). This ensures forward progress for zone
> reports and avoids failures of zones revalidation under memory pressure.
>
> While at it, also replace the hard coded 512 B sector size with the
> SECTOR_SIZE macro.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/scsi/sd_zbc.c | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-11-11 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 2:39 [f2fs-dev] [PATCH v2 0/9] Zoned block device enhancements and zone report rework Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 1/9] block: Enhance blk_revalidate_disk_zones() Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 2/9] block: cleanup the !zoned case in blk_revalidate_disk_zones Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 3/9] block: Simplify report zones execution Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 4/9] block: Remove partition support for zoned block devices Damien Le Moal
2019-11-11 6:55 ` Hannes Reinecke
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 5/9] null_blk: clean up the block device operations Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 6/9] null_blk: clean up report zones Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 7/9] null_blk: Add zone_nr_conv to features Damien Le Moal
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 8/9] scsi: sd_zbc: Cleanup sd_zbc_alloc_report_buffer() Damien Le Moal
2019-11-11 6:56 ` Hannes Reinecke [this message]
2019-11-11 10:22 ` Christoph Hellwig
2019-11-13 1:46 ` Martin K. Petersen
2019-11-11 2:39 ` [f2fs-dev] [PATCH v2 9/9] block: rework zone reporting Damien Le Moal
2019-11-13 2:16 ` [f2fs-dev] [PATCH v2 0/9] Zoned block device enhancements and zone report rework Jens Axboe
2019-11-13 2:40 ` Damien Le Moal
2019-11-13 7:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d0a5c6-0a6e-fea9-0d19-42b42bb63499@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).