From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88326C3E8C5 for ; Sun, 29 Nov 2020 10:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44BBE20771 for ; Sun, 29 Nov 2020 10:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726705AbgK2KAK (ORCPT ); Sun, 29 Nov 2020 05:00:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:34872 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbgK2KAJ (ORCPT ); Sun, 29 Nov 2020 05:00:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 99878AC55; Sun, 29 Nov 2020 09:59:27 +0000 (UTC) Subject: Re: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-29-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <18caca15-a6e7-cb4b-3028-c010922bda80@suse.de> Date: Sun, 29 Nov 2020 10:59:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-29-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1aenue9Ch7R7POAKtsLeZ3WSZkYx4AW4x" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1aenue9Ch7R7POAKtsLeZ3WSZkYx4AW4x Content-Type: multipart/mixed; boundary="3rwwiIZG2PfCZYAyWfeCUtOOaevZuulxH"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan Message-ID: <18caca15-a6e7-cb4b-3028-c010922bda80@suse.de> Subject: Re: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-29-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-29-sam@ravnborg.org> --3rwwiIZG2PfCZYAyWfeCUtOOaevZuulxH Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > Fix following W=3D1 warnings: > - Fix set but not nused variables which was used only for logging. s/nused/used s/which was/that were Otherwise Reviewed-by: Thomas Zimmermann > Fixed by introducing no_printk() to trick compiler to think variable= s > are used > - Fix kernel-doc warning by deleting an empty comment line >=20 > v2: > - Subject updated (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Kristoffer Ericson > Cc: Lee Jones > --- > drivers/video/fbdev/s1d13xxxfb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d= 13xxxfb.c > index 4541afcf9386..d1b5f965bc96 100644 > --- a/drivers/video/fbdev/s1d13xxxfb.c > +++ b/drivers/video/fbdev/s1d13xxxfb.c > @@ -45,7 +45,7 @@ > #if 0 > #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } whil= e(0) > #else > -#define dbg(fmt, args...) do { } while (0) > +#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } wh= ile (0) > #endif > =20 > /* > @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, co= nst struct fb_copyarea *area) > } > =20 > /** > - * > * s1d13xxxfb_bitblt_solidfill - accelerated solidfill function > * @info : framebuffer structure > * @rect : fb_fillrect structure >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --3rwwiIZG2PfCZYAyWfeCUtOOaevZuulxH-- --1aenue9Ch7R7POAKtsLeZ3WSZkYx4AW4x Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/DcPsFAwAAAAAACgkQlh/E3EQov+D/ PQ//Z4e8OyqjSfevVlybAeU3nUQukcFGaXEjQWcUwdu0S+zPuKlT+9Oq4w0jrjrV+szBcvmqs/lj asiS4MpWTV1gQOfqr7k6JiQ/W2ickxkm7be/P8p0hGiMaYzEyz7Rd89YiyMVqDQLaIIQagQmhRt+ jAkqzoEBn7Vt3wdQqSwWKUEYdXz7F3aVUflvYo2Nn0IG3jlA701PMCU4CqcPKko0I8e8FQfDc7/9 2a4lDslxtUX4B7NX3n7e6Ni6rC04kWR7yVBzr2YsOXrGeDvdCez0tkL6vf3SwgAcSPo/S6tG/m+o PoiK5NL6Id5hf+qosNajjYj+fIQuvfUSTOXTDigbXbisGtgXU0QAeYI2k1VKX99kZTyaKR4tN7N3 F08zBrkPU91VqFsyjzeZ3gUBHDK8Fw0EXdwfUrbRwzwysEIZHUpFj74bP7VCtUOpv/WWGN7tmQgk OtXFTD2Y2ZLxZ2AicH+hFWt5vcGL4Y2Wg5kXc7jVH5RALFIiLHEDabZwNnTtnhWLNBBfHGJb2KuD XJuil9roowZz35oQh6R+OfyQEXDxO00EW0Y5ObLW0CxPw2vu8o3eldLMNp3cY+mBrjt84KGG0Rpt WLKk3EoQuFalIRP9AUY1R13hmuq5XrBFUa7tveTeRs1TyUxAxopAuxcj+DI4IVwKZMf3hZPwGSvs mUc= =Co+r -----END PGP SIGNATURE----- --1aenue9Ch7R7POAKtsLeZ3WSZkYx4AW4x--