From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7230C63777 for ; Mon, 30 Nov 2020 09:00:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 575ED2074A for ; Mon, 30 Nov 2020 09:00:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727662AbgK3I7r (ORCPT ); Mon, 30 Nov 2020 03:59:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:40288 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727621AbgK3I7q (ORCPT ); Mon, 30 Nov 2020 03:59:46 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1CC4EAD8C; Mon, 30 Nov 2020 08:59:05 +0000 (UTC) Subject: Re: [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-8-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <1fb53984-6b19-0db2-6ed7-60e1cb3fb817@suse.de> Date: Mon, 30 Nov 2020 09:59:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201128224114.1033617-8-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HJIRrGsqj5PtOxbC0hRvnlo3IcQsYq2FP" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HJIRrGsqj5PtOxbC0hRvnlo3IcQsYq2FP Content-Type: multipart/mixed; boundary="7rrfBDNYWxCsUTfIlEAQpJA0RXEp0JiET"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Joe Perches , Kristoffer Ericson , Laurent Pinchart , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Vaibhav Gupta , Xiaofei Tan Message-ID: <1fb53984-6b19-0db2-6ed7-60e1cb3fb817@suse.de> Subject: Re: [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-8-sam@ravnborg.org> In-Reply-To: <20201128224114.1033617-8-sam@ravnborg.org> --7rrfBDNYWxCsUTfIlEAQpJA0RXEp0JiET Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > init.h define static symbols, so should only be included s/define/defines s/so should/so it should > once. Drop the include from sis.h as it is not needed. > This fixes a lot of warnings seen with a W=3D1 build. >=20 > v2: > - Update subject (Lee) >=20 > Signed-off-by: Sam Ravnborg > Cc: Thomas Winischhofer > Cc: Lee Jones Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/sis/sis.h | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/si= s.h > index 9f4c3093ccb3..d632f096083b 100644 > --- a/drivers/video/fbdev/sis/sis.h > +++ b/drivers/video/fbdev/sis/sis.h > @@ -15,7 +15,6 @@ > =20 > #include "vgatypes.h" > #include "vstruct.h" > -#include "init.h" > =20 > #define VER_MAJOR 1 > #define VER_MINOR 8 >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --7rrfBDNYWxCsUTfIlEAQpJA0RXEp0JiET-- --HJIRrGsqj5PtOxbC0hRvnlo3IcQsYq2FP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/EtFUFAwAAAAAACgkQlh/E3EQov+Dd xQ//Tb02a05Abzm3OJT3QY7MUyu9SvbEtm3Kf/Cn2pwPpOgLvJWRmAwmDMGElEcKI+/iLmLjcUpL idW0ietgp7bTzhH6Fw/dNFBwB4w1MSLIdYQT14nkPI3ebFJDhbRojz12WT/C4CZH7xVduf7Z9C+o HlswG5e9trVbZVoidTzxr8174pY2Q+S8jeHdjx+p6EEXpDX1Sa2GPKJHtGebiuiFgV+eGYDPc/a/ rp+CXKA0hdSx9HdM+p30ztQ4rjLQ6xZnN7nW7++MdX9HXwI8AhyyRPH3R2rEoYaO+8DOG04MgZol oArd9k5juwn1Pu/kYE0gPhC8kyeEZiPHEwXMHW4hzXdnMHYP/tq8SQPrXXYbSweR6+R36kBp+F6P lTrzqfjQZwttrW00ibrLQnFtagi6IsPfy5cplvrY1m+UxqghK8pVPhEJGoNa0JsCmbTSVqBRZuBM kGtQwytGTkAAzUbeJK6Y/0j1vicyke7TP6lHP9AHNyQ02S1qN/4JXjchCWWV04BGCnNb+4ZqcfYn X2UthQl9I+I4ldkBfx9P81kY5CrC9eS2g/VqkEwJwqxZgeH7/VDo7pzcQPaFfJpFzxuT891stj1+ xRBuNB7n0Z2xO21sIHLtIKZt8hNhnmribnhHRR6wVvqX7hLbAVpNOo83oG/VcSn70epWu2Txcheh 0LY= =ZeOZ -----END PGP SIGNATURE----- --HJIRrGsqj5PtOxbC0hRvnlo3IcQsYq2FP--