From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Willy Tarreau <w@1wt.eu>
Cc: b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, rdunlap@infradead.org,
gregkh@linuxfoundation.org, daniel@ffwll.ch,
yuanmingbuaa@gmail.com, nopitydays@gmail.com,
zhangyunhai@nsfocus.com, luto@amacapital.net,
torvalds@linux-foundation.org
Subject: Re: [PATCH] docs: fb: Remove framebuffer scrollback option for boot
Date: Wed, 16 Sep 2020 03:16:16 +0000 [thread overview]
Message-ID: <20200916030416.GA20404@Gentoo> (raw)
In-Reply-To: <20200916022552.GB13409@1wt.eu>
[-- Attachment #1: Type: text/plain, Size: 3814 bytes --]
On 04:25 Wed 16 Sep 2020, Willy Tarreau wrote:
Thank you so much Willy. I am trying to get the essence of your mail ...few
responses below..
>Bhaskar,
>
>your patches still all use very similar subjects and commit messages
>which are pretty confusing as they only differ by words unrelated to
>their real differences. It is important that the commit messages help
>the reader guess what is being touched, so if you're splitting your
>work into multiple patches, you need to indicate the difference in
>each message. What I can propose to make things clearer:
>
> docs: fb: Remove framebuffer scrollback boot option
> docs: fb: Remove matroxfb scrollback boot option
> docs: fb: Remove sstfb scrollback boot option
> docs: fb: Remove vesafb scrollback boot option
>
I would prefer to stick with this model , what you suggested with different
subject and more relevant text.
>Alternately they can all be merged into the first one under the same
>name, but then the detailed commit message should specifically list
>them.
>
>In addition below:
>
>On Wed, Sep 16, 2020 at 03:55:11AM +0530, Bhaskar Chowdhury wrote:
>> This patch remove the scrollback option under boot options.
>> Plus readjust the numbers for the options in that section.
>>
>> Commit 973c096f6a85(vgacon: remove software scrollback support)
>> Commit 50145474f6ef(fbcon: remove soft scrollback code)
>
>This is still not clear. The message should indicate the "why" more
>than the "what" which can be figured from the patch. In addition,
>only the fbcon commit is a cause for these changes. Last, Greg
>mentioned that the format is 'commit xxx ("subject")'.
>
>What about this:
>
> The "scrollback" boot option was removed by commit 50145474f6ef
> ("fbcon: remove soft scrollback code"), but the doc for fbcon was
> not updated. This patch updates the fbcon doc and renumbers the
> sections.
>
I lost it ...by head failed me ...do you want me copy more information text
from the actual commit??
>If you merge all your patches together, you can have this:
>
> The "scrollback" boot option was removed by commit 50145474f6ef
> ("fbcon: remove soft scrollback code"), but the fb docs were not
> updated. This patch removes reference to this option in the fbcon,
> matroxfb, sstfb and vesafb docs and renumbers the sections as needed.
>
>And please increase your version so that it's more obvious that this
>replaces previous series. Call it v3 or v4 or whatever higher than
>the highest you've ever sent so that it's easier for your readers to
>ignore the older ones. Ideally after your signed-off-by you should
>add a "---" line with a quick changelog indicating what changed from
>the previous ones (just for reviewers, this will not be merged), for
>example:
>
Okay, before sending this new set ...yesterday I wrote a mail to everyone ,
that I wanted to get rid of this damn versioning thing and will sent patches
afresh. So, ask everyone involved please ignore what have sent previously and
that mail too. I am sure that missed your eyes ...and I understand why :)
But I am still reluctant to bump up the version number and would like to sent
all the 4 patches AFRESH(which has nothing to do with the previous patchtes I
have sent) .
Can I do that Willy???
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> v3: clarify message description, update all fb drivers in the same patch
> v2: reword commit message
>
This chainlog of information in the patch getting spirial and not helpful
AFAIK. I mean, the version bumping and provide information appended to every
other following mail. If that is significant then I understand ...but for this thing....I
hope you get me...
>Hoping this helps,
>Willy
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-16 3:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 22:37 [PATCH] docs: fb: Remove framebuffer scrollback option for boot Bhaskar Chowdhury
2020-09-16 2:25 ` Willy Tarreau
2020-09-16 3:16 ` Bhaskar Chowdhury [this message]
2020-09-16 4:44 ` Willy Tarreau
2020-09-16 7:42 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916030416.GA20404@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nopitydays@gmail.com \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
--cc=yuanmingbuaa@gmail.com \
--cc=zhangyunhai@nsfocus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).