Re: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver

From: Maxime Ripard <mripard@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Helge Deller" <deller@gmx.de>,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver
Date: Thu, 25 Apr 2024 16:58:06 +0200	[thread overview]
Message-ID: <20240425-perky-myrtle-gorilla-e1e24f@penduick> (raw)
In-Reply-To: <20240425124208.2255265-1-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi,

On Thu, Apr 25, 2024 at 03:42:07PM +0300, Andy Shevchenko wrote:
> First of all, the driver was introduced when it was already
> two drivers available for Ilitek 9341 panels.
> 
> Second, the most recent (fourth!) driver has incorporated this one
> and hence, when enabled, it covers the provided functionality.
> 
> Taking into account the above, remove duplicative driver and make
> maintenance and support eaiser for everybody.
> 
> Also see discussion [1] for details about Ilitek 9341 duplication
> code.
> 
> Link: https://lore.kernel.org/r/ZXM9pG-53V4S8E2H@smile.fi.intel.com [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I think it should be the other way around and we should remove the
mipi-dbi handling from panel/panel-ilitek-ili9341.c

It's basically two drivers glued together for no particular reason and
handling two very different use cases which just adds more complexity
than it needs to.

And it's the only driver doing so afaik, so it's definitely not "least
surprise" compliant.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]