From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: remove set but not used 'ulCoreClock'
Date: Tue, 08 Sep 2020 11:37:49 +0000 [thread overview]
Message-ID: <7d8571f5-7f26-2507-291c-8a66ac3744bd@samsung.com> (raw)
In-Reply-To: <20200827130028.428893-1-yanaijie@huawei.com>
On 8/27/20 3:00 PM, Jason Yan wrote:
> This addresses the following gcc warning with "make W=1":
>
> drivers/video/fbdev/kyro/STG4000InitDevice.c: In function
> ‘SetCoreClockPLL’:
> drivers/video/fbdev/kyro/STG4000InitDevice.c:247:6: warning: variable
> ‘ulCoreClock’ set but not used [-Wunused-but-set-variable] // yanaijie
> fixed
> 247 | u32 ulCoreClock;
> | ^~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied to drm-misc-next tree, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/kyro/STG4000InitDevice.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> index 1d3f2080aa6f..edaeec2d9590 100644
> --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c
> +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> @@ -244,7 +244,6 @@ int SetCoreClockPLL(volatile STG4000REG __iomem *pSTGReg, struct pci_dev *pDev)
> {
> u32 F, R, P;
> u16 core_pll = 0, sub;
> - u32 ulCoreClock;
> u32 tmp;
> u32 ulChipSpeed;
>
> @@ -282,7 +281,7 @@ int SetCoreClockPLL(volatile STG4000REG __iomem *pSTGReg, struct pci_dev *pDev)
> if (ulChipSpeed = 0)
> return -EINVAL;
>
> - ulCoreClock = ProgramClock(REF_FREQ, CORE_PLL_FREQ, &F, &R, &P);
> + ProgramClock(REF_FREQ, CORE_PLL_FREQ, &F, &R, &P);
>
> core_pll |= ((P) | ((F - 2) << 2) | ((R - 2) << 11));
>
next prev parent reply other threads:[~2020-09-08 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200827130039eucas1p124a0c2d9912f55281386c9318013a17a@eucas1p1.samsung.com>
2020-08-27 13:00 ` [PATCH] video: fbdev: remove set but not used 'ulBestVCO' Jason Yan
2020-08-27 13:00 ` [PATCH] video: fbdev: remove set but not used 'ulCoreClock' Jason Yan
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz [this message]
2020-09-08 11:37 ` [PATCH] video: fbdev: remove set but not used 'ulBestVCO' Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8571f5-7f26-2507-291c-8a66ac3744bd@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).