Re: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device

From: Jiri Kosina <jkosina@suse.cz>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Jaya Kumar <jayakumar.lkml@gmail.com>,
	linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>,
	Nicu Pavel <npavel@ituner.com>, Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device
Date: Mon, 22 Mar 2010 08:56:38 +0000	[thread overview]
Message-ID: <alpine.LNX.2.00.1003220955000.18642@pobox.suse.cz> (raw)
In-Reply-To: <20100321171128.324a606f@neptune.home>

On Sun, 21 Mar 2010, Bruno Prémont wrote:

> > > ---
> > >  drivers/hid/Kconfig       |    7 +-
> > >  drivers/hid/hid-picolcd.c |  454 +++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 460 insertions(+), 1 deletions(-)
> > 
> > It is customary for framebuffer drivers to live in drivers/video. This
> > is the first one I've reviewed that is outside of it. Is there a good
> > reason for this one to be outside of it? If so, could you put it in
> > the comments.
> 
> I've kept all the pieces of PicoLCD driver together under hid,
> as it's a HID based device. Framebuffer is just one of its features and
> keeping pieces together makes it easier to handle.

I think it makes sense for a HID driver for this device to contain the 
framebuffer bits as well ... from user perspective, this seems to be HID 
device, with "extra" framebuffer display on it.

If framebuffer folks Ack the fb-related code, I am fine keeping it under 
drivers/hid.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.